mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

filter out NoUUID remotes from syncDataRemotes

Browse source
This commit is contained in:
Joey Hess 2016-06-09 16:38:47 -04:00
parent 43939c67d3
commit 1fed64db26
Failed to extract signature
2 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Assistant/DaemonStatus.hs
View file

@ -55,6 +55,7 @@ calcSyncRemotes = do
let good r = Remote.uuid r `elem` alive
let syncable = filter good rs
let syncdata = filter (not . remoteAnnexIgnore . Remote.gitconfig) $
filter (\r -> Remote.uuid r /= NoUUID) $
filter (not . Remote.isXMPPRemote) syncable
return $ \dstatus -> dstatus

19
doc/bugs/__34__metadata_only__34___git-remote-gcrypt_syncing_files_anyway/comment_3_79268506a1653220ddfbb45f9c61d8a7._comment Normal file
View file

@ -0,0 +1,19 @@
[[!comment format=mdwn
username="joey"
subject="""comment 3"""
date="2016-06-09T20:27:07Z"
content="""
This was fixed in [[!commit fbf5045d4f17accde9e20fa528e52cb1dce61c47]]
for `git annex sync --content`
I don't remember the immediate cause of it being in a code that that the
webapp would call, but I did add a belt-and-suspenders fix at a lower level
which I'd hope would prevent the webapp from uploading anything in any
case.
Sounds like the webapp tries to queue transfers to a NoUUID remote, and
then presumably gives up before the object gets uploaded.
Looking at the code, calcSyncRemotes does not filter out NoUUID remotes
when populating syncDataRemotes. So, I've fixed that too now.
"""]]