Fix zombie process that occurred when switching between repository views in the webapp.

Assistant/WebApp/OtherRepos.hs

@@ -61,8 +61,12 @@ getSwitchToRepositoryR repo = do
 		threadDelay 100000 -- 1/10th of a second
 		a
 
+{- Returns once the assistant has daemonized, but possibly before it's
+ - listening for web connections. -}
 startAssistant :: FilePath -> IO ()
 startAssistant repo = do
 	program <- readProgramFile
-	void $ forkIO $ void $ createProcess $
+	(_, _, _, pid) <- 
-		(proc program ["assistant"]) { cwd = Just repo }
+		createProcess $
+			(proc program ["assistant"]) { cwd = Just repo }
+	void $ checkSuccessProcess pid

debian/changelog

@@ -9,6 +9,8 @@ git-annex (4.20131102) UNRELEASED; urgency=low
   * Fix enabling of gcrypt repository accessed over ssh;
     git-annex-shell gcryptsetup had a bug that caused it to fail
     with permission denied.
+  * Fix zombie process that occurred when switching between repository
+    views in the webapp.
 
  -- Joey Hess <joeyh@debian.org>  Sat, 02 Nov 2013 14:54:36 -0400
 

doc/bugs/Zombie_processes_and__47__or_stuck_git_processes.mdwn

@@ -40,3 +40,5 @@ git-annex assistant is currently running.  Here is the output of **ps -A u | gre
 31812 pts/2    Z      0:00 [git-annex] <defunct>
 31835 ?        Ss     0:02 ssh: .git/annex/ssh/example.net [mux]
 """]]
+
+> [[fixed|done]] --[[Joey]]