mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

decided this is not a problem

Browse source
This commit is contained in:
Joey Hess 2022-06-15 14:00:56 -04:00
parent f259be7f39
commit 1ddaf7a27f
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

15
doc/bugs/worktree_overwrite_races.mdwn
View file

@ -15,3 +15,18 @@ Better would probably be for replaceWorkTreeFile to be provided with a
InodeCache of the content of the worktree file that is ok to replace. InodeCache of the content of the worktree file that is ok to replace.
Then it can move the file to a temp directory, check that it's still Then it can move the file to a temp directory, check that it's still
unmodified, and replace it. --[[Joey]] unmodified, and replace it. --[[Joey]]
> On second thought, I remember that I investigated git's behavior before
> when a checkout or pull is updating the worktree and a file is changed.
> git does not avoid races, and can overwrite user modifications. Last time
> I looked at this, I remember I decided that if git did that, it was ok
> for git-annex to also.
>
> The difference with [[add_overwrite_race]] is it caused the wrong thing
> to get added to git, which is a problem that `git add` does not have
> (probably). And git-annex already took steps to deal with writes that
> happened in the middle of a `git-annex add`. So it made sense to fix
> those problems. But extending it to this broader case is not necessary, I
> think.
>
> [[done]] --[[Joey]]