RawFilePath conversion of System.Directory
By using System.Directory.OsPath, which takes and returns OsString, which is a ShortByteString. So, things like dirContents currently have the overhead of copying that to a ByteString, but that should be less than the overhead of using Strings which often in turn were converted to RawFilePaths. Added Utility.OsString and the OsString build flag. That flag is turned on in the stack.yaml, and will be turned on automatically by cabal when built with new enough libraries. The stack.yaml change is a bit ugly, and that could be reverted for now if it causes any problems. Note that Utility.OsString.toOsString on windows is avoiding only a check of encoding that is documented as being unlikely to fail. I don't think it can fail in git-annex; if it could, git-annex didn't contain such an encoding check before, so at worst that should be a wash.
This commit is contained in:
parent
e5be81f8d4
commit
1ceece3108
34 changed files with 222 additions and 138 deletions
|
@ -8,13 +8,6 @@ Some commands like `git-annex find` use RawFilePath end-to-end.
|
|||
But this conversion is not yet complete. This is a todo to keep track of the
|
||||
status.
|
||||
|
||||
* The Abstract FilePath proposal (AFPP) has been implemented, and so a number of
|
||||
libraries like directory now have versions that operate on
|
||||
OSPath. That could be used in git-annex eg for things like
|
||||
getDirectoryContents, when built against those versions.
|
||||
(OSPath uses ShortByteString, while RawFilePath is ByteString, so
|
||||
conversion still entails a copy, eg using
|
||||
`System.OsString.Internal.fromBytes`)
|
||||
* unix has modules that operate on RawFilePath but no OSPath versions yet.
|
||||
See https://github.com/haskell/unix/issues/240
|
||||
* filepath-1.4.100 implements support for OSPath. It is bundled with
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue