mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

better response

Browse source
This commit is contained in:
Joey Hess 2020-04-15 12:17:57 -04:00
parent b241f579c0
commit 1aa7082c9a
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
doc/bugs/commits_created_despite_alwayscommit__61__false_as_of_recent_change/comment_1_793ab4d52a3a4a3a30b0e72b72ac18eb._comment
View file

@ -4,13 +4,15 @@
date="2020-04-15T16:09:02Z"
content="""
That change would lead to buggy behavior, because git-annex would then not
commit the journal files, and the optimisation prevents it reading the
stage the journal files, and the optimisation prevents it reading the
journal files, so it would operate with out of date information.
The only way to fix this, I think, is to disable the entire optimisation
when annex.alwayscommit is false and the journal is dirty.
The right fix, I think is to avoid making a commit, and instead only stage
the journal files into the annex index.
Or hmm, it should not be a problem for it to stage the journal files to the
index, but not commit the index. Not clear to me why it would be committing
even after that change, so I'll investigate that first.
But probably only when annex.alwayscommit=false and still commit when it's
true, because leaving staged changes in the annex index without
committing them risks git gc deleting the objects used, which is a
documented gotcha with annex.alwayscommit=false but not something users
should otherwise need to worry about.
"""]]