changelog for Kyle's other fix, and close bug

This commit is contained in:
Joey Hess 2020-03-26 13:18:41 -04:00
parent 39131b55ca
commit 173465592f
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
3 changed files with 17 additions and 0 deletions

View file

@ -9,6 +9,8 @@ git-annex (8.20200310) UNRELEASED; urgency=medium
* add --force-small: Fix a bug that, when adding a symbolic link,
checked in the content of the file the symlink pointed to.
Thanks, Kyle Meyer for noticing and for the patch.
* add --force-small: Fix failure when passed a modified submodule.
Thanks, Kyle Meyer for noticing and for the patch.
-- Joey Hess <id@joeyh.name> Mon, 16 Mar 2020 12:43:33 -0400

View file

@ -125,3 +125,4 @@ index 56e6fb236..72aae5f3c 100644
[[!meta author=kyle]]
[[!tag projects/datalad]]
> [[applied|done]] --[[Joey]]

View file

@ -0,0 +1,14 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2020-03-26T17:15:02Z"
content="""
Really well done, thank you. Applied both.
About the only thing I have to add is, I wonder if it would be better for
--force-small to just temporarily disable the clean filter and always
use git add. Seems that might be less likely to run into this kind of
breakage. OTOH, it looks like you've found all the possible bugs in it
already... So I suppose I'll wait until the next bug is found in it to
think about doing that. ;-)
"""]]