mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

webapp: When $HOME is a git repository, and has been initialized for use by git-annex, opening the webapp went ahead and ran the assistant there, annexing all files. Since this is almost certianly not desirable, especially when the user is just opening the webapp from a dekstop menu which happens to run it in $HOME, the webapp will now not treat such a $HOME git repository as a git-annex repository.

Browse source
This commit is contained in:
Joey Hess 2016-04-13 14:07:50 -04:00
parent fe1628db11
commit 1010482bc7
Failed to extract signature
4 changed files with 43 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/Assistant_will_annex_your_files_on_startup_if_you_create_a_repository_in___126____47__.mdwn
View file

@ -21,3 +21,5 @@ The assistant shouldn't do anything unless I tell it to. Currently, I cannot pla
### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders)
I use git annex for managing the image and video resources on my website and it works fine for that.
> HOME git repo guard added, [[done]] --[[Joey]]

24
doc/bugs/Assistant_will_annex_your_files_on_startup_if_you_create_a_repository_in___126____47__/comment_6_ed1b53ceef3e7a499b92e6f3f0f6d672._comment Normal file
View file

@ -0,0 +1,24 @@
[[!comment format=mdwn
username="joey"
subject="""comment 6"""
date="2016-04-13T17:43:34Z"
content="""
So, I see that you *did* tell git-annex to treat your home git repo as a
git-annex repo.
And, starting the the assistant/webapp from inside a git annex repository is
intended to start them running in that repository. This behavior makes a
lot of sense in general. It's consistent with running any other git command
inside a git repository causing that command to run on that repository.
I guess that the issue here is, opening the git-annex webapp from a menu
causes the program to run with its working directory set to HOME. But in
this case, the HOME is only incidental, the intent is not to start the
webapp/assistant in that repository.
Seems kind of hard for the assistant to determine intent though.
So, the best that can be done, I suppose, is to make starting the webapp
in the HOME git repository behave as if that git repository was not
initialized for use by git-annex.
"""]]