mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

UNLOCKCONTENT is not a top-level request

Browse source 
proxyRequest was treating UNLOCKCONTENT as a separate request.
That made it possible for there to be two different connections to the
proxied remote, with LOCKCONTENT being sent to one, and UNLOCKCONTENT
to the other one. A protocol error.

git-annex testremote now passes against a http proxied remote.
This commit is contained in:
Joey Hess 2024-07-26 20:37:38 -04:00
parent a3dab58be2
commit 0fb86d2916
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
4 changed files with 16 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

14
doc/todo/git-annex_proxies.mdwn
View file

@ -28,20 +28,6 @@ Planned schedule of work:
## work notes
* This against a http proxied remote leads to a protocol error:
git-annex move foo --to origin-c
git-annex get foo --from origin-c
ERROR expected UNLOCKCONTENT
May need to run the commands a few times before it happens.
I think it's because proxyRequest treats LOCKCONTENT as a single
command+reponse, with UNLOCKCONTENT separately. So it's possible for
there to be two different connections to the proxied remote,
with LOCKCONTENT being sent to one, and UNLOCKCONTENT to the other one.
* test http server proxying with special remotes
* Make http server support clusters.