mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

version: Avoid error message when entire output is not read

Browse source 
Sponsored-by: Dartmouth College's Datalad project
This commit is contained in:
Joey Hess 2023-05-19 15:00:57 -04:00
parent 39f33a9988
commit 0f89d221bd
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
4 changed files with 32 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG
View file

@ -66,6 +66,7 @@ git-annex (10.20230408) UNRELEASED; urgency=medium
annex.synccontent.
* sync: Added -g as a short option for --no-content.
* Fix bug in -z handling of trailing NUL in input.
* version: Avoid error message when entire output is not read.
-- Joey Hess <id@joeyh.name> Sat, 08 Apr 2023 13:57:18 -0400

3
Command/Version.hs
View file

@ -78,5 +78,6 @@ showRawVersion = do
putStr BuildInfo.packageversion
hFlush stdout -- no newline, so flush
-- Ignore failure to write so that this command can eg be piped to head.
vinfo :: String -> String -> IO ()
vinfo k v = putStrLn $ k ++ ": " ++ v
vinfo k v = void $ tryIO $ putStrLn $ k ++ ": " ++ v

11
doc/bugs/dropkey_-z_does_not_drop_etc/comment_6_d6377ddfb9d907d56c70141b0c3a8a32._comment Normal file
View file

@ -0,0 +1,11 @@
[[!comment format=mdwn
username="joey"
subject="""comment 6"""
date="2023-05-19T18:54:53Z"
content="""
Aha, thanks for clearing up that `git-annex version` does that! That seems
like a bit of a bug on its own really.
.. Fixed that.
"""]]

18
doc/bugs/dropkey_-z_does_not_drop_etc/comment_7_57b63abb8ccb7fbbd71afd599cb9ef5c._comment Normal file
View file

@ -0,0 +1,18 @@
[[!comment format=mdwn
username="joey"
subject="""comment 7"""
date="2023-05-19T18:55:35Z"
content="""
The reason dropkeys does not error on an unknown key is that it's entirely
possible to get a repository into a state where a key's content is present
but the key is otherwise unknown to git-annex. Eg, it doesn't have any
location tracking information for it, there are no files in the git repo
that point to it, etc.
It makes sense to support dropping the content of such a key.
And, dropkeys intentionally operates the same on a key when its content is
not present as it does when the content is present and it successfully
dropped it. Because in either case the result is now that the specified
key's content is not present.
"""]]