importfeed --relaxed: Avoid hitting the urls of items in the feed.

Annex/Init.hs

@@ -138,8 +138,10 @@ probeCrippledFileSystem = do
 		createSymbolicLink f f2
 		nukeFile f2
 		preventWrite f
-		-- Should be unable to write to the file, but some crippled
+		-- Should be unable to write to the file, unless
+		-- running as root, but some crippled
 		-- filesystems ignore write bit removals.
+		unlessM 
 		not <$> catchBoolIO (writeFile f "2" >> return True)
 #endif
 

Command/AddUrl.hs

@@ -182,7 +182,7 @@ startWeb o s = go $ fromMaybe bad $ parseURI urlstring
 	regulardownload url = do
 		pathmax <- liftIO $ fileNameLengthLimit "."
 		urlinfo <- if relaxedOption o
-			then pure $ Url.UrlInfo True Nothing Nothing
+			then pure Url.assumeUrlExists
 			else Url.withUrlOptions (Url.getUrlInfo urlstring)
 		file <- adjustFile o <$> case fileOption o of
 			Just f -> pure f

Command/ImportFeed.hs

@@ -172,7 +172,9 @@ performDownload opts cache todownload = case location todownload of
 			r <- Remote.claimingUrl url
 			if Remote.uuid r == webUUID || rawOption opts
 				then do
-					urlinfo <- Url.withUrlOptions (Url.getUrlInfo url)
+					urlinfo <- if relaxedOption opts
+						then pure Url.assumeUrlExists
+						else Url.withUrlOptions (Url.getUrlInfo url)
 					maybeToList <$> addUrlFile (relaxedOption opts) url urlinfo f
 				else do
 					res <- tryNonAsync $ maybe

Utility/Url.hs

@@ -20,6 +20,7 @@ module Utility.Url (
 	exists,
 	UrlInfo(..),
 	getUrlInfo,
+	assumeUrlExists,
 	download,
 	downloadQuiet,
 	parseURIRelaxed
@@ -104,6 +105,9 @@ data UrlInfo = UrlInfo
 	, urlSuggestedFile :: Maybe FilePath
 	}
 
+assumeUrlExists :: UrlInfo
+assumeUrlExists = UrlInfo True Nothing Nothing
+
 {- Checks that an url exists and could be successfully downloaded,
  - also returning its size and suggested filename if available. -}
 getUrlInfo :: URLString -> UrlOptions -> IO UrlInfo

debian/changelog

@@ -13,6 +13,7 @@ git-annex (5.20150813) UNRELEASED; urgency=medium
     http.
   * Avoid building the assistant on the hurd, since an inotify equivilant
     is not yet implemented in git-annex for the hurd.
+  * importfeed --relaxed: Avoid hitting the urls of items in the feed.
 
  -- Joey Hess <id@joeyh.name>  Wed, 12 Aug 2015 14:31:01 -0400
 

doc/bugs/importfeed_--relaxed_fails_with_HEAD-rejecting_servers.mdwn

@@ -34,3 +34,5 @@ I ran into this bug trying to importfeed various BBC podcasts. For instance:
 ### What version of git-annex are you using? On what operating system?
 
 git-annex version: 5.20150731-1 on a quite up-to-date debian unstable.
+
+> Thanks for a nice test case. [[fixed|done]] --[[Joey]]

doc/git-annex-addurl.mdwn

@@ -25,7 +25,8 @@ be used to get better filenames.
 
 * `--fast`
 
-  Avoid immediately downloading the url.
+  Avoid immediately downloading the url. The url is still checked
+  (via HEAD) to verify that it exists, and to get its size if possible.
 
 * `--relaxed`