mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

avoid double work in git-annex init

Browse source 
reconcileStaged was doing a redundant scan to scannAnnexedFiles.

It would probably make sense to move the body of scannAnnexedFiles
into reconcileStaged, the separation does not really serve any purpose.

Sponsored-by: Dartmouth College's Datalad project
This commit is contained in:
Joey Hess 2021-06-07 16:50:14 -04:00
parent 6ceb31a30a
commit 0f10f208a7
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
5 changed files with 93 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

14
doc/bugs/significant_performance_regression_impacting_datal/comment_4_85d1031d2b51c0fc1271c283d8ee7888._comment Normal file
View file

@ -0,0 +1,14 @@
[[!comment format=mdwn
username="joey"
subject="""comment 4"""
date="2021-06-07T20:22:24Z"
content="""
Turns out `git-annex init` got a lot slower than it had to, it was doing
the same kind of scan twice. I think that probably explains much of the
slowdown you saw. (Although it still needs to do somewhat more work than
before, but also does it more efficiently than before.)
Also I've optimised the update scan's use of git, around a 20% speedup,
although I don't know if your test case speed was impacted much by that
scan anyway.
"""]]

9
doc/bugs/significant_performance_regression_impacting_datal/comment_5_b0f1e94e96cf8fe992425cf81f8d1105._comment Normal file
View file

@ -0,0 +1,9 @@
[[!comment format=mdwn
username="joey"
subject="""comment 5"""
date="2021-06-07T20:42:34Z"
content="""
Looking at the CI log, I don't see any past runs that took 1h 46min.
A month ago they were taking 2h 6min. Let's see if the changes I'm pushing
now drop it back to that.
"""]]