avoid double work in git-annex init
reconcileStaged was doing a redundant scan to scannAnnexedFiles. It would probably make sense to move the body of scannAnnexedFiles into reconcileStaged, the separation does not really serve any purpose. Sponsored-by: Dartmouth College's Datalad project
This commit is contained in:
parent
6ceb31a30a
commit
0f10f208a7
5 changed files with 93 additions and 38 deletions
|
@ -0,0 +1,14 @@
|
|||
[[!comment format=mdwn
|
||||
username="joey"
|
||||
subject="""comment 4"""
|
||||
date="2021-06-07T20:22:24Z"
|
||||
content="""
|
||||
Turns out `git-annex init` got a lot slower than it had to, it was doing
|
||||
the same kind of scan twice. I think that probably explains much of the
|
||||
slowdown you saw. (Although it still needs to do somewhat more work than
|
||||
before, but also does it more efficiently than before.)
|
||||
|
||||
Also I've optimised the update scan's use of git, around a 20% speedup,
|
||||
although I don't know if your test case speed was impacted much by that
|
||||
scan anyway.
|
||||
"""]]
|
|
@ -0,0 +1,9 @@
|
|||
[[!comment format=mdwn
|
||||
username="joey"
|
||||
subject="""comment 5"""
|
||||
date="2021-06-07T20:42:34Z"
|
||||
content="""
|
||||
Looking at the CI log, I don't see any past runs that took 1h 46min.
|
||||
A month ago they were taking 2h 6min. Let's see if the changes I'm pushing
|
||||
now drop it back to that.
|
||||
"""]]
|
Loading…
Add table
Add a link
Reference in a new issue