avoid getting creds from environment during autoenable

When autoenabling special remotes of type S3, weddav, or glacier, do not
take login credentials from environment variables, as the user may not be
expecting the autoenable to happen, and may have those set for other
purposes.
This commit is contained in:
Joey Hess 2021-03-17 09:41:12 -04:00
parent 02e74c010b
commit 0e44c252c8
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
14 changed files with 72 additions and 37 deletions

View file

@ -0,0 +1,16 @@
[[!comment format=mdwn
username="joey"
subject="""comment 2"""
date="2021-03-17T13:37:01Z"
content="""
Ok, I've made autoenable not take creds from the environment, which will
avoid the problem.
If there are any external special remotes that might behave similarly,
it would need an extension to the external special remote protocol to
support them. Currently `INITREMOTE` is sent during auto-enable, and so
the protocol would need to have `ENABLEREMOTE` and `AUTOENBLEREMOTE` added
to it. Since that would need an extension and I don't know if any externals
actually look at env vars etc at (auto)enable time, I've skipped doing it
for now.
"""]]