mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Windows: Fix hang when adding several files at once.

Browse source
This commit is contained in:
Joey Hess 2013-06-14 17:35:45 -04:00
parent e02fdd2270
commit 0e05613083
4 changed files with 35 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

15
doc/bugs/windows_port_-_git_annex_add_hangs_when_adding_17_files_at_once_or_more_.mdwn
View file

@ -180,3 +180,18 @@ info"]
# End of transcript or log.
"""]]
> Reproduced this, and git update-index was in fact not hanging.
> Instead, after that was done, it tried to stop the git hash-object
> process, and this hung.
>
> It seems that the use of runInteractiveProcess is at fault somehow,
> and I guess it must be due to it opening a pipe for stderr, which
> I don't need or want. Perhaps I need to ensure I read from that pipe,
> or windows keeps the process from terminating. (Unix would just toss the piped
> data away.)
>
> That was the only place runInteractiveProcess was used, so I replaced
> it with an alternative that lets stderr be inherited. With this change,
> I have successfully added 1000 files to the annex in one go, with no
> hang. Provisionally [[done]]. --[[Joey]]