mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

dup stdio handles for P2P proxy

Browse source 
Special remotes might output to stdout, or read from stdin, which would
mess up the P2P protocol. So dup the handles to avoid any such problem.
This commit is contained in:
Joey Hess 2024-07-01 10:04:45 -04:00
parent cecd151e23
commit 0dfdc9f951
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
3 changed files with 17 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

7
doc/todo/git-annex_proxies.mdwn
View file

@ -45,13 +45,6 @@ For June's work on [[design/passthrough_proxy]], remaining todos:
rather than PUT-FROM or ALREADY-HAVE. Verify that the client processes
that ok and displays it to the user.
* If a special remote outputs to stdout, or reads from stdin, that will
mess up the P2P protocol. Move the special remote proxying into a
separate process perhaps, which can be run with stdout and stdin
redirected? Or, fix any special remotes that might do that. Are
there any left? External special remotes certainly don't since that would
mess up their own protocol. Hook special remotes can though.
* Streaming download from proxied special remotes. See design.
* Check annex.diskreserve when proxying for special remotes.