mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

so close

Browse source
This commit is contained in:
Joey Hess 2022-01-12 15:25:35 -04:00
parent 63851bfec4
commit 0ba7f2ec91
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 25 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

25
doc/bugs/shared_setting_of_git_causes_annex__39__ed_files_to_be_writeable__33__/comment_10_2e61ccc41839b8da70ad26d31e40ad74._comment Normal file
View file

@ -0,0 +1,25 @@
[[!comment format=mdwn
username="joey"
subject="""comment 10"""
date="2022-01-12T19:14:10Z"
content="""
This would almost work:
Continue taking a shared lock of the content
file when locking to prevent dropping. That does not need write access,
only an exclusive lock does, so the content file can have its write bit
removed. Also lock the new lock file, with a shared lock to prevent
dropping, or an exclusive when dropping.
The old git-annex version, when dropping, will fail to exclusively lock the
content file, either because it's not writable, or because of a shared
lock intended to prevent dropping. So a git-annex drop that was in progress
may start to fail, but it will not lose any data.
Problem: The old git-annex version, when locking to prevent dropping
(eg git-annex move --from remote),
will take the shared lock of the content file. If the new git-annex version
is locking to drop, it will also take the shared lock of the content file,
followed by the exlusive lock of the new lock file. So the old git-annex will
not be able to prevent the new git-annex from dropping.
"""]]