From 0ae63d5eecc40c79e45c08853909cf9aa1200c71 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Thu, 21 May 2020 13:06:46 -0400 Subject: [PATCH] comment --- ...2_b279bd82612c0bee486c877e700ccbe4._comment | 18 ++++++++++++++++++ ...1_48953f4f0eacdba05b200f972204270d._comment | 9 +++++++++ 2 files changed, 27 insertions(+) create mode 100644 doc/bugs/__34__Cannot_handle_files_this_big__34___error_for_unlocked_files/comment_2_b279bd82612c0bee486c877e700ccbe4._comment create mode 100644 doc/bugs/git_annex_creds_are_not_embedded_with_newer_git-annex_clients/comment_1_48953f4f0eacdba05b200f972204270d._comment diff --git a/doc/bugs/__34__Cannot_handle_files_this_big__34___error_for_unlocked_files/comment_2_b279bd82612c0bee486c877e700ccbe4._comment b/doc/bugs/__34__Cannot_handle_files_this_big__34___error_for_unlocked_files/comment_2_b279bd82612c0bee486c877e700ccbe4._comment new file mode 100644 index 0000000000..5e1db4285f --- /dev/null +++ b/doc/bugs/__34__Cannot_handle_files_this_big__34___error_for_unlocked_files/comment_2_b279bd82612c0bee486c877e700ccbe4._comment @@ -0,0 +1,18 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 2""" + date="2020-05-21T16:54:48Z" + content=""" +I don't think there's any reason why git should need to allocate memory for +the whole file. All it's doing is reading the file and sending it over a +pipe, and git-annex actually hangs up the pipe before reading anything. +So git could read a few bytes, try to send them, and give up. + +The last time I looked at it, in [[!commit a96972015dd76271b46432151e15d5d38d7151ff]] +having git-annex close the pipe immediately did avoid git overallocating +memory. I don't know what else git-annex could do to avoid any bad behavior +from git. + +If your git is older than 2.5, it would certainly explain it, since the +above workaround needed git 2.5. +"""]] diff --git a/doc/bugs/git_annex_creds_are_not_embedded_with_newer_git-annex_clients/comment_1_48953f4f0eacdba05b200f972204270d._comment b/doc/bugs/git_annex_creds_are_not_embedded_with_newer_git-annex_clients/comment_1_48953f4f0eacdba05b200f972204270d._comment new file mode 100644 index 0000000000..821d963951 --- /dev/null +++ b/doc/bugs/git_annex_creds_are_not_embedded_with_newer_git-annex_clients/comment_1_48953f4f0eacdba05b200f972204270d._comment @@ -0,0 +1,9 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 1""" + date="2020-05-21T16:34:34Z" + content=""" +I tried this and the result is that git-annex get from S3 fails. While I do +think it should be writing the creds cache file, the failure to get is the +actual bug symptom. +"""]]