mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix gitAnnexLink to not be absolute on Windows

Browse source 
Windows: Fix reversion that caused the path used to link to annexed
content include the drive letter and full path, rather than being
relative. (`git annex fix` will fix up after this problem).

I've not identified the commit that brought the reversion (probably it
happened this spring when I was removing MisingH and last touched
Utility.Path). Likely commit 18b9a4b802?

The problem is that relPathDirToFile got called two paths that had the
slashes different ways around. Since takeDrive includes the first slash,
this made two paths on the same drive seem different and it bailed.

(ifdefs around this to avoid doing extra work on non-windows)

This commit was sponsored by Jack Hill on Patreon.
This commit is contained in:
Joey Hess 2017-10-25 19:04:26 -04:00
parent d428f66cdd
commit 0ae2ac282e
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
3 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/windows_annex_link_wrong.mdwn
View file

@ -2,3 +2,5 @@ On windows, the links to .git/annex/objects are no longer relative; include
drive letter and full path.
This used to not be the case; it must have gotten broken. --[[Joey]]
> [[fixed|done]]