This commit is contained in:
Joey Hess 2025-05-14 12:42:20 -04:00
parent e166a06323
commit 0ab6772ff9
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 42 additions and 0 deletions

View file

@ -0,0 +1,14 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2025-05-14T16:29:46Z"
content="""
It's not repository OR key, dead can be used with multiple keys, multiple
repositories, or a combination of keys and repositories.
(The automatically generated --help does not make it clear that --key
can be used repeatedly, but the man page does and is correct. I guess that
optparse-applicative --help does not try to distinguish between options
that can be repeated vs options where a later option overrides an earlier
one.)
"""]]

View file

@ -0,0 +1,28 @@
[[!comment format=mdwn
username="joey"
subject="""comment 2"""
date="2025-05-14T16:34:22Z"
content="""
I think arguably dead should be able to operate on paths too. If a user has
lost the only copy of a file, but not deleted the annex link, it would
be easier to use the path than looking up the key.
Since dead refuses to do anything when there's still a recorded location for
a key, there would not be any risk of operating on files whose data has not
been lost.
(There would be some ambiguity, eg "." can refer to both the "here"
repository, or all files in the current directory. For that matter,
the name of a repository could also be ambiguous with a filename.)
Making it reject "here" when provided with additional parameters that are
not repositories would conflict with such a change.
I realize that it's annoying to make a mistake like you made, but it's also
not hard to undo it once you realize that you've made "here" dead.
A better guard against that mistake might be for it to refuse to mark the
current repository as dead, since it still exists. But there are probably
workflows where a repository gets marked as dead just before `rm -rf` of it,
which that would break.
"""]]