Avoid backtraces on expected failures when built with ghc 8; only use backtraces for unexpected errors.
ghc 8 added backtraces on uncaught errors. This is great, but git-annex was using error in many places for a error message targeted at the user, in some known problem case. A backtrace only confuses such a message, so omit it. Notably, commands like git annex drop that failed due to eg, numcopies, used to use error, so had a backtrace. This commit was sponsored by Ethan Aubin.
This commit is contained in:
parent
69915c6c9b
commit
0a4479b8ec
116 changed files with 287 additions and 270 deletions
|
@ -210,7 +210,7 @@ waitLock (Seconds timeout) lockfile = go timeout
|
|||
=<< tryLock lockfile
|
||||
| otherwise = do
|
||||
hPutStrLn stderr $ show timeout ++ " second timeout exceeded while waiting for pid lock file " ++ lockfile
|
||||
error $ "Gave up waiting for possibly stale pid lock file " ++ lockfile
|
||||
giveup $ "Gave up waiting for possibly stale pid lock file " ++ lockfile
|
||||
|
||||
dropLock :: LockHandle -> IO ()
|
||||
dropLock (LockHandle lockfile _ sidelock) = do
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue