mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

full analysis

Browse source
This commit is contained in:
Joey Hess 2018-11-05 18:25:55 -04:00
parent 44769d9285
commit 0a0242224d
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 25 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

25
doc/bugs/annex_get_-J_16_via_ssh_stalls_/comment_26_a3d803f25795365c9651d2ec023d9145._comment Normal file
View file

@ -0,0 +1,25 @@
[[!comment format=mdwn
username="joey"
subject="""comment 26"""
date="2018-11-05T21:32:20Z"
content="""
tryLockExclusive is returning Nothing before the hang, when runTransfer
tries to lock the transfer log file. So runTransfer returns without
running the transfer action.
Aha! ReadContent tries to run a transfer, and it calls
sinkfile with sender in the transfer action.
Never run, and so DATA never gets sent and indeed git-annex-shell is
waiting for the next command.
Using alwaysRunTransfer would solve this; that's what Command.SendKey does.
And it would let concurrent downloads from a annex.pidlock remote work.
However, I'm not entirely happy with that, because as this shows any bug in
there that prevents the transfer action being run will lead to a protocol
stall. Seems it ought to detect when the transfer action didn't run, and
error out, somehow.
Note that StoreContent also runs a transfer, but that does not involve
running a callback. So, might be ok. But, it may not consume the DATA
from the sender, so I need to look at it too.
"""]]