mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Work around a bug in Network.URI's handling of bracketed ipv6 addresses.

Browse source
This commit is contained in:
Joey Hess 2011-05-06 15:21:30 -04:00
parent f1fbe33cfe
commit 078a6fbd76
3 changed files with 37 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

16
doc/bugs/git-annex_incorrectly_parses_bare_IPv6_addresses.mdwn
View file

@ -41,3 +41,19 @@ git-annex: bad url ssh://[2001/~/0:53aa:64c:24ef:5ce4:2ef9:cdda]:/home/paulprote
(Note that both these .git/config entries work fine with "git fetch".)
-- Asheesh.
> Technically, this seems to be a bug in the haskell URI library; it honors
> the `[]` in parsing, but does not remove them when the URI is queried for
> the host part.
<pre>
Prelude Network.URI> let (Just u) = parseURI "http://foo@[2001:0:53aa:64c:24ef:5ce4:2ef9:cdda]/bar"
Prelude Network.URI> let (Just a) = uriAuthority u
Prelude Network.URI> uriRegName a
"[2001:0:53aa:64c:24ef:5ce4:2ef9:cdda]"
Prelude Network.URI> isIPv6address $ uriRegName a
False
</pre>
> I have filed a [bug upstream](http://trac.haskell.org/network/ticket/40), and put a workaround in git-annex. [[done]]
> --[[Joey]]