From 07215cfeb54c4bcc7524e5eb472c587414adce61 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Fri, 18 Feb 2022 13:18:05 -0400 Subject: [PATCH] complete annex.skipunknown transition annex.skipunknown now defaults to false, so commands like `git annex get foo*` will not silently skip over files/dirs that are not checked into git. Sponsored-by: Brock Spratlen on Patreon --- CHANGELOG | 3 +++ NEWS | 9 +++++++++ Types/GitConfig.hs | 2 +- doc/git-annex.mdwn | 4 +--- .../complete_annex.skipunknown_transition_in_2022.mdwn | 2 ++ 5 files changed, 16 insertions(+), 4 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 392620d9e5..31f1f3d653 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,5 +1,8 @@ git-annex (10.20220128) UNRELEASED; urgency=medium + * annex.skipunknown now defaults to false, so commands like + `git annex get foo*` will not silently skip over files/dirs that are + not checked into git. * adb: Avoid find failing with "Argument list too long" * Pass --no-textconv when running git diff internally. * Fix git-annex forget propagation between repositories. diff --git a/NEWS b/NEWS index 188824068f..489f86e9c3 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,12 @@ +git-annex (10.20220218) upstream; urgency=medium + + Transition notice: Commands like `git-annex get foo*` have changed to error + out when some of files are not checked into the repository. To get back the + previous behavior of silently skipping unknown files, use git config + to set annex.skipunknown to true. + + -- Joey Hess Fri, 18 Feb 2022 13:12:21 -0400 + git-annex (8.20211028) upstream; urgency=medium This version of git-annex removes support for communicating with git-annex diff --git a/Types/GitConfig.hs b/Types/GitConfig.hs index 46362de897..d54514fc08 100644 --- a/Types/GitConfig.hs +++ b/Types/GitConfig.hs @@ -233,7 +233,7 @@ extractGitConfig configsource r = GitConfig , annexCommitMode = if getbool (annexConfig "allowsign") False then ManualCommit else AutomaticCommit - , annexSkipUnknown = getbool (annexConfig "skipunknown") True + , annexSkipUnknown = getbool (annexConfig "skipunknown") False , annexAdjustedBranchRefresh = fromMaybe -- parse as bool if it's not a number (if getbool "adjustedbranchrefresh" False then 1 else 0) diff --git a/doc/git-annex.mdwn b/doc/git-annex.mdwn index 08eff60715..a1ce1baa4e 100644 --- a/doc/git-annex.mdwn +++ b/doc/git-annex.mdwn @@ -836,9 +836,7 @@ repository, using [[git-annex-config]]. See its man page for a list.) Set to false to make it an error for commands like "git-annex get" to be asked to operate on files that are not checked into git. - - The default is currently true, but is planned to change to false in a - release in 2022. + (This is the default in recent versions of git-annex.) Note that, when annex.skipunknown is false, a command like "git-annex get ." will fail if no files in the current directory are checked into git, diff --git a/doc/todo/complete_annex.skipunknown_transition_in_2022.mdwn b/doc/todo/complete_annex.skipunknown_transition_in_2022.mdwn index 9d5f13dc24..a8de0c61b6 100644 --- a/doc/todo/complete_annex.skipunknown_transition_in_2022.mdwn +++ b/doc/todo/complete_annex.skipunknown_transition_in_2022.mdwn @@ -2,3 +2,5 @@ annex.skipunknown should be changed to default to false in early 2022. This transition was started in mid 2020 and there should have been plenty of time for people to learn about it and either set their preferred behavior or change workflows for the new behavior. + +> [[done]] --[[Joey]]