mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

comment

Browse source
This commit is contained in:
Joey Hess 2022-01-03 13:53:34 -04:00
parent 9e18cd28ad
commit 0584e096d1
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Remote/Adb.hs
View file

@ -202,6 +202,7 @@ retrieve' serial src dest =
showOutput -- make way for adb pull output showOutput -- make way for adb pull output
liftIO $ boolSystem "adb" $ mkAdbCommand serial liftIO $ boolSystem "adb" $ mkAdbCommand serial
[ Param "pull" [ Param "pull"
, Param "-a"
, File $ fromAndroidPath src , File $ fromAndroidPath src
, File dest , File dest
] ]

17
doc/bugs/adb_pull_does_not_preserve_timestamp/comment_1_b695826d1f948249b496c055b4d745df._comment Normal file
View file

@ -0,0 +1,17 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2022-01-03T17:48:38Z"
content="""
Git does not preserve timestamps. So this is kind of out of scope.
While git-annex will sometimes preserve timestamps when it's easy to do so,
there are no guarantees. Most special remotes do not preserve any
timestamps in either direction.
It might be that `adb pull -a` would fix this. But that also preserves
the permissions, and pulling in random permissions for annex object files
could lead to arbitrary breakage (imagine a suid executable for example).
So it would need to clear the permissions. The complexity does not seem
worth trying to support a thing that is generally out of scope.
"""]]