improve p2p protocol handling of requested object not available
Avoid spurious "verification of content failed" message when downloading content from a ssh or tor remote fails due to the remote no longer having a copy of the content. The P2P protocol already handled this case by sending DATA 0, followed by VALID. But VALID was not really right, because the data is not the requested data. So, send DATA 0, followed by INVALID. Old versions of git-annex handle INVALID the same as VALID in this case. Now new versions avoid displaying an incorrect message. It would be better for the P2P protocol to have a different way to indicate this, like perhaps sending INVALID without DATA. But that would be a breaking change and need a new protocol verison. Since INVALID already is part of the protocol and already needs to be handled, using it for this special case too seems ok, and avoids the complication of another protocol version. This commit was sponsored by Jochen Bartl on Patreon.
This commit is contained in:
parent
ca4a928635
commit
0540e987b3
4 changed files with 22 additions and 2 deletions
|
@ -172,6 +172,14 @@ runLocal runst runner a = case a of
|
|||
runner validitycheck >>= \case
|
||||
Right (Just Valid) ->
|
||||
return (rightsize, UnVerified)
|
||||
Right (Just Invalid) | l == 0 ->
|
||||
-- Special case, for when
|
||||
-- content was not
|
||||
-- available to send,
|
||||
-- which is indicated by
|
||||
-- sending 0 bytes and
|
||||
-- Invalid.
|
||||
return (False, UnVerified)
|
||||
_ -> do
|
||||
-- Invalid, or old protocol
|
||||
-- version. Validity is not
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue