mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

update

Browse source
This commit is contained in:
Joey Hess 2020-11-18 15:16:49 -04:00
parent 682829c200
commit 043eee0cb5
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 23 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGELOG
View file

@ -9,6 +9,9 @@ git-annex (8.20201117) UNRELEASED; urgency=medium
and for easier scripting.
* init: When writing hook scripts, set all execute bits, not only
the user execute bit.
* Fix hang when an external special remote program exited but
the stderr pipe to it was left open, due to a daemon having inherited
the file descriptor.
-- Joey Hess <id@joeyh.name> Mon, 16 Nov 2020 09:38:32 -0400

20
doc/bugs/Buggy_external_special_remote_stalls_after_7245a9e/comment_4_746ffcf575f91bc3d156b279bcdf8ae2._comment Normal file
View file

@ -0,0 +1,20 @@
[[!comment format=mdwn
username="joey"
subject="""comment 4"""
date="2020-11-18T17:23:21Z"
content="""
Seems the problem with hWaitForInput happens when running it concurrently
with hGetLine on the same handle. When I run it sequentially, it does seem
to work. Ok.. I was able to implement hGetLineUntilExitOrEOF that seems to
work.
I've converted it to use that, and the test case for this bug is fixed.
Also, the sleep based workaround
in [[!commit aa492bc65904a19f22ffdfc20d7a5e7052e2f54d]] is removed,
and it uses hGetLineUntilExitOrEOF instead.
However, I still want to do the audit of other things that pipe stderr.
Some of them don't do line based input, so will need a different function
than hGetLineUntilExitOrEOF. Leaving this bug open until that audit is
done.
"""]]