mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

comment

Browse source
This commit is contained in:
Joey Hess 2021-05-13 12:05:24 -04:00
parent d960d72b9d
commit 03f46b95e6
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 19 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

19
doc/todo/support_macOS__39___cp_-c___40__cp_--reflink_equivalent__41__/comment_9_5097e4ac096d1b0b9c06c544b9217e22._comment Normal file
View file

@ -0,0 +1,19 @@
[[!comment format=mdwn
username="joey"
subject="""comment 9"""
date="2021-05-13T15:51:41Z"
content="""
fork/exec can end up being fairly significant overhead when the files are
small enough. And, at least on linux systems, most people are probably not
using a filesystem supporting CoW, so most people would pay that perf
penalty. That's why the current code is optimised to avoid it,
at least in places where it's seemed worthwhile.
I'll suggest again: Just start with copyCoW, leave copyFileExternal
not doing CoW copies, I'll accept that easy patch. And then if any of
the 6 or so call sites of copyFileExternal end up being ones you want to
make support CoW on OSX, convert them to use tryCopyCoW.
(Alternatively, if there were a haskell library that provided the syscall
that does a CoW copy, it could just use it.)
"""]]