mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix nasty reversion in the last release that broke sync --content's handling of many preferred content expressions.

Browse source 
The type checker should have noticed this, but the changes to mapM
that make it accept any Traversable hid the fact that it was not being
passed a list at all. Thus, what should have returned an empty list most
of the time instead returned [""] which was treated as the name of the
associated file, with disasterout consequences.

When I have time, I should add a test case checking what sync --content
drops. I should also consider replacing mapM with one re-specialized to
lists.
This commit is contained in:
Joey Hess 2016-01-26 14:28:43 -04:00
parent 3ddfa7bf1d
commit 039e83ed5d
Failed to extract signature
5 changed files with 20 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/wanted___61___present_gets_ignored_in___39__git_annex_sync_--content__39__.mdwn
View file

@ -16,3 +16,5 @@ git-annex version 6.20160114 on Arch Linux.
### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders)
This behaviour is relatively recent. Until some time ago everything worked as expected with the expression above.
> [[fixed|done]] --[[Joey]]

11
doc/bugs/wanted___61___present_gets_ignored_in___39__git_annex_sync_--content__39__/comment_1_410adea7a16e77756579556a2270a458._comment Normal file
View file

@ -0,0 +1,11 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2016-01-26T18:22:48Z"
content="""
I think it's worse than that, it lost track of the filename, so
preferred content expressions with include= or exclude= will also do the
wrong thing.
Going to have to rush out a release fixing this..
"""]]