From 03662e4d832aa339abc0b49f701c367e07902cd5 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 12 Nov 2024 14:31:28 -0400 Subject: [PATCH] comments --- ..._482b88a01eb307794c1dd3f9ce8d7938._comment | 10 ++++++++ ..._76df8f40ff2fa1f5429e31ecedba6090._comment | 23 +++++++++++++++++++ 2 files changed, 33 insertions(+) create mode 100644 doc/bugs/importtree_with_versioning__61__yes__58___check_first/comment_2_482b88a01eb307794c1dd3f9ce8d7938._comment create mode 100644 doc/bugs/importtree_with_versioning__61__yes__58___check_first/comment_3_76df8f40ff2fa1f5429e31ecedba6090._comment diff --git a/doc/bugs/importtree_with_versioning__61__yes__58___check_first/comment_2_482b88a01eb307794c1dd3f9ce8d7938._comment b/doc/bugs/importtree_with_versioning__61__yes__58___check_first/comment_2_482b88a01eb307794c1dd3f9ce8d7938._comment new file mode 100644 index 0000000000..582cf1b6b3 --- /dev/null +++ b/doc/bugs/importtree_with_versioning__61__yes__58___check_first/comment_2_482b88a01eb307794c1dd3f9ce8d7938._comment @@ -0,0 +1,10 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 2""" + date="2024-11-12T17:35:16Z" + content=""" +Made a pull request to aws + +(As sometimes S3 maintainer of aws, I'll probably accept it if nobody +objects to it.) +"""]] diff --git a/doc/bugs/importtree_with_versioning__61__yes__58___check_first/comment_3_76df8f40ff2fa1f5429e31ecedba6090._comment b/doc/bugs/importtree_with_versioning__61__yes__58___check_first/comment_3_76df8f40ff2fa1f5429e31ecedba6090._comment new file mode 100644 index 0000000000..50496de282 --- /dev/null +++ b/doc/bugs/importtree_with_versioning__61__yes__58___check_first/comment_3_76df8f40ff2fa1f5429e31ecedba6090._comment @@ -0,0 +1,23 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 3""" + date="2024-11-12T17:35:50Z" + content=""" +Wait though... We have signature=anonymous. So git-annex does in fact know +that this special remote is read-only. git-annex will never try to write to +it (even if the bucket somehow allowed anonymous writes) as long as it's +configured with signature=anonymous. + +So, it could just avoid trying to set versioning when signature=anonymous, +and assume the bucket has versioning enabled. + +Hmm, in lockContentS3, when versioning is enabled, it calls +checkVersioning, which checks if a S3 version ID has been recorded for the +file. What if the bucket did not actually have versioning enabled? Then an +import from it would not record a S3 version ID. That would make this, and +other places like checkKey that expect versioned buckets to have S3 version +IDs fail in unexpected ways. + +So, I guess I'm inclined to not go down this read-only path, and instead wait for +aws to get updated and use that. +"""]]