diff --git a/debian/changelog b/debian/changelog index f59df474fc..207c1feeef 100644 --- a/debian/changelog +++ b/debian/changelog @@ -12,6 +12,9 @@ git-annex (6.20160218) UNRELEASED; urgency=medium * Avoid crashing when built with MagicMime support, but when the magic database cannot be loaded. * Include magic database in the linux and OSX standalone builds. + * Fix memory leak when hashing files, which triggered during fsck + when an external hash program was not used. + (This leak was introduced in version 6.20160114.) -- Joey Hess Thu, 18 Feb 2016 13:09:21 -0400 diff --git a/doc/bugs/checksum_loads_whole_file_into_memory.mdwn b/doc/bugs/checksum_loads_whole_file_into_memory.mdwn index 9b121843af..ece3281059 100644 --- a/doc/bugs/checksum_loads_whole_file_into_memory.mdwn +++ b/doc/bugs/checksum_loads_whole_file_into_memory.mdwn @@ -16,3 +16,9 @@ environment as the 6.20160217-g95bbdb8 that has the problem. > problem got fixed. But, reverting that commit breaks the test suite on > windows and has a FD leak, so is not desirable. This needs more > investigation. --[[Joey]] + +>> I see it now, the checksum is a String and it was only forced to WHNF, +>> so the hashing didn't fully complete and the file got buffered. +>> Probably only occurred when fscking, and not when adding a file, +>> due to differing use patterns of the checksum. +>> [[fixed|done]] --[[Joey]]