2018-03-12 20:28:54 +00:00
|
|
|
Some things to do with the [[design/P2P_protocol]]
|
|
|
|
are works in progress, needing a future flag day to complete.
|
|
|
|
|
|
|
|
## VERSION over tor
|
|
|
|
|
|
|
|
Old versions of git-annex, before 6.20180312, which speak the P2P protocol
|
|
|
|
over tor, don't support VERSION, and attempting to negotiate a version
|
|
|
|
will cause the server to hang up the connection. To deal with this
|
|
|
|
historical bug, the version is not currently negotiated when using the
|
|
|
|
protocol over tor. At some point in the future, when all peers can be
|
|
|
|
assumed to be upgraded, this should be changed.
|
|
|
|
|
2021-10-11 19:53:49 +00:00
|
|
|
> [[done]] --[[Joey]]
|
|
|
|
|
2018-03-12 20:28:54 +00:00
|
|
|
## git-annex-shell fallbacks
|
|
|
|
|
|
|
|
When using git-annex-shell p2pio, git-annex assumes that if it exits 1,
|
|
|
|
it does not support that, and falls back to the old sendkey/rerecvkey,
|
|
|
|
etc.
|
|
|
|
|
|
|
|
At some point in the future, once all git-annex and git-annex-shell
|
|
|
|
can be assumed to be upgraded to 6.20180312, this fallback can be removed.
|
|
|
|
It will allows removing a lot of code from git-annex-shell and a lot of
|
|
|
|
fallback code from Remote.Git.
|
2020-01-30 19:22:05 +00:00
|
|
|
|
2021-10-11 19:53:49 +00:00
|
|
|
> [[done]] --[[Joey]]
|
remove git-annex-shell compat code
* Removed support for accessing git remotes that use versions of
git-annex older than 6.20180312.
* git-annex-shell: Removed several commands that were only needed to
support git-annex versions older than 6.20180312.
(lockcontent, recvkey, sendkey, transferinfo, commit)
The P2P protocol was added in that version, and used ever since, so
this code was only needed for interop with older versions.
"git-annex-shell commit" is used by newer git-annex versions, though
unnecessarily so, because the p2pstdio command makes a single commit at
shutdown. Luckily, it was run with stderr and stdout sent to /dev/null,
and non-zero exit status or other exceptions are caught and ignored. So,
that was able to be removed from git-annex-shell too.
git-annex-shell inannex, recvkey, sendkey, and dropkey are still used by
gcrypt special remotes accessed over ssh, so those had to be kept.
It would probably be possible to convert that to using the P2P protocol,
but it would be another multi-year transition.
Some git-annex-shell fields were able to be removed. I hoped to remove
all of them, and the very concept of them, but unfortunately autoinit
is used by git-annex sync, and gcrypt uses remoteuuid.
The main win here is really in Remote.Git, removing piles of hairy fallback
code.
Sponsored-by: Luke Shumaker
2021-10-11 19:35:54 +00:00
|
|
|
|
2020-01-30 19:22:05 +00:00
|
|
|
[[!tag confirmed]]
|