git-annex/Command/AddUnused.hs

{- git-annex command
 -
 - Copyright 2012 Joey Hess <joey@kitenet.net>
 -
 - Licensed under the GNU GPL version 3 or higher.
 -}

module Command.AddUnused where

import Common.Annex
import Logs.Location
import Command
import qualified Command.Add
import Command.Unused (withUnusedMaps, UnusedMaps(..), startUnused)
import Types.Key

cmd :: [Command]
cmd = [notDirect $ command "addunused" (paramRepeating paramNumRange)
	seek SectionMaintenance "add back unused files"]

seek :: CommandSeek
seek = withUnusedMaps start

start :: UnusedMaps -> Int -> CommandStart
start = startUnused "addunused" perform
	(performOther "bad")
	(performOther "tmp")

perform :: Key -> CommandPerform
perform key = next $ do
	logStatus key InfoPresent
	Command.Add.addLink file key Nothing
	return True
  where
	file = "unused." ++ key2file key

{- The content is not in the annex, but in another directory, and
 - it seems better to error out, rather than moving bad/tmp content into
 - the annex. -}
performOther :: String -> Key -> CommandPerform
performOther other _ = error $ "cannot addunused " ++ other ++ "content"
-												addunused: New command, the opposite of dropunused, it relinks unused content into the git repository.

											
										
										
											2012-05-02 18:59:05 +00:00
+								{- git-annex command
 								 -
 								 - Copyright 2012 Joey Hess <joey@kitenet.net>
 								 -
 								 - Licensed under the GNU GPL version 3 or higher.
 								 -}
 								module Command.AddUnused where
 								import Common.Annex
-												addurl: Bugfix: Did not properly add file in direct mode.

											
										
										
											2013-04-11 17:35:52 +00:00
+								import Logs.Location
-												addunused: New command, the opposite of dropunused, it relinks unused content into the git repository.

											
										
										
											2012-05-02 18:59:05 +00:00
+								import Command
 								import qualified Command.Add
-												--unused: New switch that makes git-annex operate on all data found by the last run of git annex unused. Supported by fsck, get, move, copy.

											
										
										
											2013-07-03 19:26:59 +00:00
+								import Command.Unused (withUnusedMaps, UnusedMaps(..), startUnused)
-												add routes to pause/start/cancel transfers

This commit includes a paydown on technical debt incurred two years ago,
when I didn't know that it was bad to make custom Read and Show instances
for types. As the routes need Read and Show for Transfer, which includes a
Key, and deriving my own Read instance of key was not practical,
I had to finally clean that up.

So the compact Key read and show functions are now file2key and key2file,
and Read and Show are now derived instances.

Changed all code that used the old instances, compiler checked.
(There were a few places, particularly in Command.Unused, and the test
suite where the Show instance continue to be used for legitimate
comparisons; ie show key_x == show key_y (though really in a bloom filter))

											
										
										
											2012-08-08 20:06:01 +00:00
+								import Types.Key
-												addunused: New command, the opposite of dropunused, it relinks unused content into the git repository.

											
										
										
											2012-05-02 18:59:05 +00:00
-												doh't use "def" for command definitions, it conflicts with Data.Default.def

											
										
										
											2014-10-14 18:20:10 +00:00
+								cmd :: [Command]
 								cmd = [notDirect $ command "addunused" (paramRepeating paramNumRange)
-												add section metadata to all commands

Not yet used .. mindless train work.

											
										
										
											2013-03-24 22:28:21 +00:00
+									seek SectionMaintenance "add back unused files"]
-												addunused: New command, the opposite of dropunused, it relinks unused content into the git repository.

											
										
										
											2012-05-02 18:59:05 +00:00
-												fix inversion of control in CommandSeek (no behavior changes)

I've been disliking how the command seek actions were written for some
time, with their inversion of control and ugly workarounds.

The last straw to fix it was sync --content, which didn't fit the
Annex [CommandStart] interface well at all. I have not yet made it take
advantage of the changed interface though.

The crucial change, and probably why I didn't do it this way from the
beginning, is to make each CommandStart action be run with exceptions
caught, and if it fails, increment a failure counter in annex state.
So I finally remove the very first code I wrote for git-annex, which
was before I had exception handling in the Annex monad, and so ran outside
that monad, passing state explicitly as it ran each CommandStart action.

This was a real slog from 1 to 5 am.

Test suite passes.

Memory usage is lower than before, sometimes by a couple of megabytes, and
remains constant, even when running in a large repo, and even when
repeatedly failing and incrementing the error counter. So no accidental
laziness space leaks.

Wall clock speed is identical, even in large repos.

This commit was sponsored by an anonymous bitcoiner.

											
										
										
											2014-01-20 08:11:42 +00:00
+								seek :: CommandSeek
 								seek = withUnusedMaps start
-												addunused: New command, the opposite of dropunused, it relinks unused content into the git repository.

											
										
										
											2012-05-02 18:59:05 +00:00
 								start :: UnusedMaps -> Int -> CommandStart
-												block all commands that don't work in direct mode

I left status working in direct mode, although it doesn't show correct
stats for known annex keys.

											
										
										
											2012-12-29 18:28:19 +00:00
+								start = startUnused "addunused" perform
 									(performOther "bad")
 									(performOther "tmp")
-												addunused: New command, the opposite of dropunused, it relinks unused content into the git repository.

											
										
										
											2012-05-02 18:59:05 +00:00
 								perform :: Key -> CommandPerform
-												addurl: Bugfix: Did not properly add file in direct mode.

											
										
										
											2013-04-11 17:35:52 +00:00
+								perform key = next $ do
 									logStatus key InfoPresent
-												add, import, assistant: Better preserve the mtime of symlinks, when when adding content that gets deduplicated.

Note that this turned out to remove a syscall, not add any expense.
Otherwise, I would not have done it.

											
										
										
											2013-09-25 20:07:11 +00:00
+									Command.Add.addLink file key Nothing
-												addurl: Bugfix: Did not properly add file in direct mode.

											
										
										
											2013-04-11 17:35:52 +00:00
+									return True
-												where indentation

											
										
										
											2012-11-12 05:05:04 +00:00
+								  where
 									file = "unused." ++ key2file key
-												addunused: New command, the opposite of dropunused, it relinks unused content into the git repository.

											
										
										
											2012-05-02 18:59:05 +00:00
 								{- The content is not in the annex, but in another directory, and
 								 - it seems better to error out, rather than moving bad/tmp content into
 								 - the annex. -}
 								performOther :: String -> Key -> CommandPerform
 								performOther other _ = error $ "cannot addunused " ++ other ++ "content"