git-annex/doc/todo/optimise_by_converting_Map_to_HashMap.mdwn

13 lines
487 B
Text
Raw Normal View History

2021-05-20 15:18:46 +00:00
Map is used in lots of places, but HashMap is faster, at least sometimes.
It would be worth benchmarking some of the more performance critical
parts with HashMap. The uses in AnnexRead especially.
(Set and HashSet too.)
--[[Joey]]
2021-09-11 21:01:39 +00:00
> Note that HashMap perfomance can degrade if an attacker provides keys
> that collide. This has been used to DOS aeson parsing. (Which could
> affect a few parts of git-annex in theory). So if converting to HashMap,
> need to consider this. --[[Joey]]