2021-05-20 15:18:46 +00:00
|
|
|
Map is used in lots of places, but HashMap is faster, at least sometimes.
|
|
|
|
|
It would be worth benchmarking some of the more performance critical
|
|
|
|
|
parts with HashMap. The uses in AnnexRead especially.
|
|
|
|
|
|
|
|
|
|
(Set and HashSet too.)
|
|
|
|
|
|
|
|
|
|
--[[Joey]]
|
2021-09-11 21:01:39 +00:00
|
|
|
|
|
|
|
|
> Note that HashMap perfomance can degrade if an attacker provides keys
|
|
|
|
|
> that collide. This has been used to DOS aeson parsing. (Which could
|
2021-10-11 14:06:36 +00:00
|
|
|
> affect a few parts of git-annex in theory; fixed in aeson-2.0.1.0).
|
|
|
|
|
> So if converting to HashMap, need to consider this. --[[Joey]]
|
