git-annex/doc/bugs/embedcreds_with_external_special_remotes.mdwn

### Please describe the problem.
git-annex-remote-googledrive uses SETCREDS and GETCREDS to let git-annex handle the credentials. According to the [documentation](https://git-annex.branchable.com/design/external_special_remote_protocol/) it should be stored inside the git-annex branch when using hyprid or pubkey encryption. However, this does not happen. Even setting embedcreds to yes does not change anything.

### What steps will reproduce the problem?
    git annex initremote testremote type=external externaltype=googledrive prefix=test keyid=<key> encryption=pubkey
or

    git annex initremote testremote type=external externaltype=googledrive embedcreds=yes prefix=test keyid=<key> encryption=pubkey
    

### What version of git-annex are you using? On what operating system?
    git-annex version: 8.20200309-g14a4a9f4c
    build flags: Assistant Webapp Pairing S3 WebDAV Inotify DBus DesktopNotify TorrentParser MagicMime Feeds Testsuite
    dependency versions: aws-0.22 bloomfilter-2.0.1.0 cryptonite-0.26 DAV-1.3.4 feed-1.3.0.0 ghc-8.8.3 http-client-0.6.4.1 persistent-sqlite-2.10.6.2 torrent-10000.1.1 uuid-1.3.13 yesod-1.6.0.1
    key/value backends: SHA256E SHA256 SHA512E SHA512 SHA224E SHA224 SHA384E SHA384 SHA3_256E SHA3_256 SHA3_512E SHA3_512 SHA3_224E SHA3_224 SHA3_384E SHA3_384 SKEIN256E SKEIN256 SKEIN512E SKEIN512 BLAKE2B256E BLAKE2B256 BLAKE2B512E BLAKE2B512 BLAKE2B160E BLAKE2B160 BLAKE2B224E BLAKE2B224 BLAKE2B384E BLAKE2B384 BLAKE2BP512E BLAKE2BP512 BLAKE2S256E BLAKE2S256 BLAKE2S160E BLAKE2S160 BLAKE2S224E BLAKE2S224 BLAKE2SP256E BLAKE2SP256 BLAKE2SP224E BLAKE2SP224 SHA1E SHA1 MD5E MD5 WORM URL
    remote types: git gcrypt p2p S3 bup directory rsync web bittorrent webdav adb tahoe glacier ddar git-lfs hook external
    operating system: linux x86_64
    supported repository versions: 8
    upgrade supported from repository versions: 0 1 2 3 4 5 6 7
    local repository version: 8


### Please provide any additional information below.

[[!format sh """
% git annex initremote g4 type=external externaltype=googledrive embedcreds=yes prefix=test keyid=***redacted*** encryption=pubkey --debug
[...]
[2020-06-11 12:14:11.622651546] git-annex-remote-googledrive[1] --> SETCREDS credentials ***redacted***
[2020-06-11 12:14:11.623213097] chat: gpg ["--quiet","--trust-model","always","--decrypt"]
[2020-06-11 12:14:11.761559468] process done ExitSuccess
[2020-06-11 12:14:11.761663537] chat: gpg ["--quiet","--trust-model","always","--batch","--recipient","***redacted***","--encrypt","--no-encrypt-to","--no-default-recipient","--force-mdc","--no-textmode"]
[2020-06-11 12:14:11.765603345] process done ExitSuccess
[2020-06-11 12:14:11.765697179] git-annex-remote-googledrive[1] --> INITREMOTE-SUCCESS
[...]
% git show git-annex
commit abb4cf685439115dffc393bb73cd3bb499f6aaec (git-annex)
Author: Silvio Ankermann <silvio@localhost>
Date:   Thu Jun 11 12:14:11 2020 +0200

    update

diff --git a/remote.log b/remote.log
index 5c72883..2d29c9c 100644
--- a/remote.log
+++ b/remote.log
@@ -1,3 +1,4 @@
+1da660c2-fe07-4dcb-aca6-12f2cfdfff52 cipher=***redacted*** cipherkeys==***redacted*** embedcreds=yes encryption=pubkey externaltype=googledrive name=g4 prefix=test root_id==***redacted*** token= type=external timestamp=1591870451.772978233s
***redacted***

diff --git a/uuid.log b/uuid.log
index b9196be..4a9fe4d 100644
--- a/uuid.log
+++ b/uuid.log
@@ -1,3 +1,4 @@
+1da660c2-fe07-4dcb-aca6-12f2cfdfff52 g4 timestamp=1591870451.772033937s
***redacted***

"""]]
I can see that gpg is called after SETCREDS and I would have expected there to be an additional config "credentials":

[[!format sh """
+1da660c2-fe07-4dcb-aca6-12f2cfdfff52 cipher=***redacted*** cipherkeys==***redacted*** credentials=*encrypted_creds* embedcreds=yes encryption=pubkey externaltype=googledrive name=g4 prefix=test root_id==***redacted*** token= type=external timestamp=1591870451.772978233s
"""]]



### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders)
Of course ;) In fact. I've actually never used embedcreds. I just had an [issue](https://github.com/Lykos153/git-annex-remote-googledrive/issues/48) raised about it on github.

> [[fixed|done]] --[[Joey]]