git-annex/doc/bugs/external_remote_hGetContents_handle_error.mdwn

### Please describe the problem.

A follow on from https://git-annex.branchable.com/bugs/Failing_to_execute_bash_remotes_windows/

After noticing your note about it still being possible to run external scripts locally (don't know why I didn't try this!), I tried it. I guess this is related to the reading of the shebang?
This may be fixed already, so I'm sorry if I'm rehashing things!


### What steps will reproduce the problem?

[[!format sh """
$ git init
$ git annex init
$ cp `which git-annex-remote-rclone` .
$ git annex initremote test type=external externaltype=rclone encryption=none

initremote test
git-annex: git-annex-remote-rclone: hGetContents: illegal operation (delayed read on closed handle)
failed
git-annex: initremote: 1 failed
"""]]


### What version of git-annex are you using? On what operating system?

Same as before, windows, git-bash

    git-annex version: 6.20170214-g2233a50
    build flags: Assistant Webapp Pairing Testsuite S3(multipartupload)(storageclasses) WebDAV ConcurrentOutput TorrentParser Feeds Quvi
    key/value backends: SHA256E SHA256 SHA512E SHA512 SHA224E SHA224 SHA384E SHA384 SHA3_256E SHA3_256 SHA3_512E SHA3_512 SHA3_224E SHA3_224 SHA3_384E SHA3_384 SKEIN256E SKEIN256  SKEIN512E SKEIN512 SHA1E SHA1 MD5E MD5 WORM URL
    remote types: git gcrypt p2p S3 bup directory rsync web bittorrent webdav tahoe glacier ddar hook external
    local repository version: 5
    supported repository versions: 3 5 6
    upgrade supported from repository versions: 2 3 4 5
    operating system: mingw32 i386


### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders)

Thanks for the quick response earlier. I hope this is helpful information. Keep up the great work! :)

> Reproduced this bug, and I've committed a fix. [[done]] --[[Joey]]
2017-03-09 12:08:07 +00:00			`### Please describe the problem.`

			`A follow on from https://git-annex.branchable.com/bugs/Failing_to_execute_bash_remotes_windows/`

			`After noticing your note about it still being possible to run external scripts locally (don't know why I didn't try this!), I tried it. I guess this is related to the reading of the shebang?`
			`This may be fixed already, so I'm sorry if I'm rehashing things!`


			`### What steps will reproduce the problem?`

			`[[!format sh """`
			`$ git init`
			`$ git annex init`
			$ cp `which git-annex-remote-rclone` .
			`$ git annex initremote test type=external externaltype=rclone encryption=none`

			`initremote test`
			`git-annex: git-annex-remote-rclone: hGetContents: illegal operation (delayed read on closed handle)`
			`failed`
			`git-annex: initremote: 1 failed`
			`"""]]`



			`### What version of git-annex are you using? On what operating system?`

			`Same as before, windows, git-bash`

			`git-annex version: 6.20170214-g2233a50`
			`build flags: Assistant Webapp Pairing Testsuite S3(multipartupload)(storageclasses) WebDAV ConcurrentOutput TorrentParser Feeds Quvi`
			`key/value backends: SHA256E SHA256 SHA512E SHA512 SHA224E SHA224 SHA384E SHA384 SHA3_256E SHA3_256 SHA3_512E SHA3_512 SHA3_224E SHA3_224 SHA3_384E SHA3_384 SKEIN256E SKEIN256 SKEIN512E SKEIN512 SHA1E SHA1 MD5E MD5 WORM URL`
			`remote types: git gcrypt p2p S3 bup directory rsync web bittorrent webdav tahoe glacier ddar hook external`
			`local repository version: 5`
			`supported repository versions: 3 5 6`
			`upgrade supported from repository versions: 2 3 4 5`
			`operating system: mingw32 i386`



			`### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders)`

			`Thanks for the quick response earlier. I hope this is helpful information. Keep up the great work! :)`
Windows: Fix bug in shell script shebang lookup code that caused a "delayed read on closed handle" error. The bug was that withFile closes the handle afterwards, but the content of the file was not read due to laziness. Using readFile avoids it. This commit was sponsored by Nick Daly on Patreon. 2017-03-13 20:20:52 +00:00
			`> Reproduced this bug, and I've committed a fix. [[done]] --[[Joey]]`