git-annex/Command/Upgrade.hs

{- git-annex command
 -
 - Copyright 2011 Joey Hess <joey@kitenet.net>
 -
 - Licensed under the GNU GPL version 3 or higher.
 -}

module Command.Upgrade where

import Common.Annex
import Command
import Upgrade

def :: [Command]
def = [dontCheck repoExists $ -- because an old version may not seem to exist
	command "upgrade" paramNothing seek
		SectionMaintenance "upgrade repository layout"]

seek :: CommandSeek
seek = withNothing start

start :: CommandStart
start = do
	showStart "upgrade" "."
	r <- upgrade False
	next $ next $ return r
add explicit upgrade command 2011-03-16 19:48:26 +00:00			`{- git-annex command`
			`-`
			`- Copyright 2011 Joey Hess <joey@kitenet.net>`
			`-`
			`- Licensed under the GNU GPL version 3 or higher.`
			`-}`

			`module Command.Upgrade where`

rename 2011-10-05 20:02:51 +00:00			`import Common.Annex`
add explicit upgrade command 2011-03-16 19:48:26 +00:00			`import Command`
need to explicitly run upgrade now 2011-03-19 22:58:10 +00:00			`import Upgrade`
add explicit upgrade command 2011-03-16 19:48:26 +00:00
clean up check selection code This new approach allows filtering out checks from the default set that are not appropriate for a command, rather than having to list every check that is appropriate. It also reduces some boilerplate. Haskell does not define Eq for functions, so I had to go a long way around with each check having a unique id. Meh. 2011-10-29 19:19:05 +00:00			`def :: [Command]`
			`def = [dontCheck repoExists $ -- because an old version may not seem to exist`
add section metadata to all commands Not yet used .. mindless train work. 2013-03-24 22:28:21 +00:00			`command "upgrade" paramNothing seek`
			`SectionMaintenance "upgrade repository layout"]`
add explicit upgrade command 2011-03-16 19:48:26 +00:00
fix inversion of control in CommandSeek (no behavior changes) I've been disliking how the command seek actions were written for some time, with their inversion of control and ugly workarounds. The last straw to fix it was sync --content, which didn't fit the Annex [CommandStart] interface well at all. I have not yet made it take advantage of the changed interface though. The crucial change, and probably why I didn't do it this way from the beginning, is to make each CommandStart action be run with exceptions caught, and if it fails, increment a failure counter in annex state. So I finally remove the very first code I wrote for git-annex, which was before I had exception handling in the Annex monad, and so ran outside that monad, passing state explicitly as it ran each CommandStart action. This was a real slog from 1 to 5 am. Test suite passes. Memory usage is lower than before, sometimes by a couple of megabytes, and remains constant, even when running in a large repo, and even when repeatedly failing and incrementing the error counter. So no accidental laziness space leaks. Wall clock speed is identical, even in large repos. This commit was sponsored by an anonymous bitcoiner. 2014-01-20 08:11:42 +00:00			`seek :: CommandSeek`
			`seek = withNothing start`
add explicit upgrade command 2011-03-16 19:48:26 +00:00
remove command type definitions These were a mistake, they make the type signatures harder to read and less flexible. The CommandSeek, CommandStart, CommandPerform, and CommandCleanup types were a good idea, but composing them with the parameters expected is going too far. 2011-09-15 20:50:49 +00:00			`start :: CommandStart`
add explicit upgrade command 2011-03-16 19:48:26 +00:00			`start = do`
v3 upgrade code works but write the index file a lot, so slow 2011-06-23 06:30:20 +00:00			`showStart "upgrade" "."`
v5 for direct mode, with automatic upgrade This includes storing the current state of the HEAD ref, which git annex sync is going to need, but does not make sync use it. 2013-11-05 20:42:59 +00:00			`r <- upgrade False`
refactor some boilerplate 2011-05-15 06:02:46 +00:00			`next $ next $ return r`