mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1
electron/shell/renderer
History
Exact
trop[bot] 5c32d27eca
 fix: add MicrotasksScope for worker exit emit in ContextWillDestroy (#51350) 
a39108c5a4 (#47244) replaced gin_helper::EmitEvent with a direct
`v8::Function::Call()` in `WebWorkerObserver::ContextWillDestroy`
to avoid re-entering the microtask checkpoint during worker teardown.

V8 `DCHECK()`s that a policy is set. Under the old code path, this
happened with a node::CallbackScope. Under the new code path, it's
possible for a policy to not be set, causing that `DCHECK()` to fail.

This PR copies a39108c5a4's changes in `ShareEnvironmentWithContext()`:
it explicitly adds a `kDoNotRunMicrotasks` scope.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2026-04-27 18:43:07 -05:00
..
api fix: use CreateDataProperty when copying objects across contextBridge (#51086) 2026-04-16 12:42:49 -04:00
extensions fix: clang-tidy warnings, pt. 1 (#49083) 2026-01-09 22:57:38 -08:00
printing chore: bump chromium to 146.0.7666.0 (main) (#49528) 2026-02-12 12:37:56 -05:00
resources/mac fix: disable MallocNanoZone on mac (#33704) 2022-04-28 10:28:27 -04:00
browser_exposed_renderer_interfaces.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
browser_exposed_renderer_interfaces.h chore: add ELECTRON_ prefix to C++ include guards (#31925) 2021-11-22 16:34:31 +09:00
content_settings_observer.cc feat: route deprecated sync clipboard read through permission checks (#45377) 2025-02-05 15:13:29 +09:00
content_settings_observer.h feat: route deprecated sync clipboard read through permission checks (#45377) 2025-02-05 15:13:29 +09:00
electron_api_service_impl.cc chore: bump chromium to 141.0.7390.7 (main) (#48212) 2025-09-08 12:57:15 +02:00
electron_api_service_impl.h feat: route deprecated sync clipboard read through permission checks (#45377) 2025-02-05 15:13:29 +09:00
electron_autofill_agent.cc chore: bump chromium to 148.0.7778.0 (42-x-y) (#50813) 2026-04-09 11:57:10 +02:00
electron_autofill_agent.h chore: bump chromium to 134.0.6968.0 (main) (#45172) 2025-01-23 23:07:43 -05:00
electron_ipc_native.cc perf: avoid a little extra work in InvokeIpcCallback() (#48456) 2025-10-04 21:52:53 -07:00
electron_ipc_native.h refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 2) (#47879) 2025-07-28 10:22:27 -05:00
electron_render_frame_observer.cc chore: bump chromium to 143.0.7485.0 (main) (#48618) 2025-10-23 08:30:29 -05:00
electron_render_frame_observer.h chore: bump chromium to 144.0.7506.0 (main) (#48744) 2025-11-03 21:26:16 -08:00
electron_renderer_client.cc feat: capture JS stack trace on renderer OOM (#50911) 2026-04-27 16:44:00 -04:00
electron_renderer_client.h refactor: avoid deprecated v8::Context::GetIsolate() calls pt 3 context get isolate pt 3 (#47901) 2025-07-30 09:14:38 -05:00
electron_sandboxed_renderer_client.cc feat: capture JS stack trace on renderer OOM (#50911) 2026-04-27 16:44:00 -04:00
electron_sandboxed_renderer_client.h chore: bump chromium to 147.0.7719.0 (main) (#50061) 2026-03-08 06:22:11 +09:00
electron_smooth_round_rect.cc chore: bump chromium to 144.0.7512.1 (main) (#48768) 2025-11-07 10:13:45 -05:00
electron_smooth_round_rect.h feat: Corner Smoothing CSS rule (Reland) (#46278) 2025-03-31 11:22:23 -05:00
oom_stack_trace.cc feat: capture JS stack trace on renderer OOM (#50911) 2026-04-27 16:44:00 -04:00
oom_stack_trace.h feat: capture JS stack trace on renderer OOM (#50911) 2026-04-27 16:44:00 -04:00
preload_realm_context.cc chore: bump chromium to 144.0.7512.1 (main) (#48768) 2025-11-07 10:13:45 -05:00
preload_realm_context.h chore: bump chromium to 141.0.7390.7 (main) (#48212) 2025-09-08 12:57:15 +02:00
preload_utils.cc refactor: remove gin_helper::Arguments (#48374) 2025-10-03 14:10:29 -05:00
preload_utils.h refactor: remove gin_helper::Arguments (#48374) 2025-10-03 14:10:29 -05:00
renderer_client_base.cc feat: capture JS stack trace on renderer OOM (#50911) 2026-04-27 16:44:00 -04:00
renderer_client_base.h feat: capture JS stack trace on renderer OOM (#50911) 2026-04-27 16:44:00 -04:00
service_worker_data.cc refactor: avoid deprecated v8::Context::GetIsolate() calls pt 3 context get isolate pt 3 (#47901) 2025-07-30 09:14:38 -05:00
service_worker_data.h refactor: avoid deprecated v8::Context::GetIsolate() calls pt 3 context get isolate pt 3 (#47901) 2025-07-30 09:14:38 -05:00
web_worker_observer.cc fix: add MicrotasksScope for worker exit emit in ContextWillDestroy (#51350) 2026-04-27 18:43:07 -05:00
web_worker_observer.h fix: nodeIntegrationInWorker not working in AudioWorklet (#51005) 2026-04-13 07:59:06 -05:00