electron/lib/browser
trop[bot] 880b1e08e7
refactor: remove dead named-window lookup from guest-window-manager (#50497)
The frameNamesToWindow map was a holdover from the BrowserWindowProxy
IPC shim. Since nativeWindowOpen became the only code path, Blink's
FrameTree::FindOrCreateFrameForNavigation resolves named window targets
directly in the renderer, scoped to the opener's browsing context
group. When a matching named window exists, Blink navigates it without
ever sending a CreateNewWindow IPC to the browser, so this map was
never consulted in the legitimate same-opener case.

The only time the map found a match was when two unrelated renderers
happened to use the same target name, in which case openGuestWindow
would short-circuit before consuming the guest WebContents that
Chromium had already created for the new window, leaking it.

Adds a test verifying Blink handles same-opener named-target reuse
end-to-end without any browser-side tracking.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Sam Attard <sattard@anthropic.com>
2026-03-26 11:46:12 -04:00
..
api fix: don't re-parse URL unnecessarily when handling dialogs (#50399) 2026-03-20 13:46:37 -04:00
.eslintrc.json chore: add missing .eslintrc.json files to limit imports properly (#35719) 2022-09-20 13:25:33 -05:00
default-menu.ts build: add import/order eslint rule (#44085) 2024-10-02 19:10:44 -07:00
devtools.ts feat: service worker preload scripts for improved extensions support (#44411) 2025-01-31 09:32:45 -05:00
guest-view-manager.ts chore: bump chromium to 140.0.7281.0 (main) (#47616) 2025-07-14 13:42:37 -07:00
guest-window-manager.ts refactor: remove dead named-window lookup from guest-window-manager (#50497) 2026-03-26 11:46:12 -04:00
init.ts fix: better shortcut registration and app icon matching on Wayland (#50051) 2026-03-04 16:43:44 +01:00
ipc-dispatch.ts refactor: dispatch IPC messages from Session (#45452) 2025-02-17 16:36:28 -05:00
ipc-main-impl.ts build: add import/order eslint rule (#44085) 2024-10-02 19:10:44 -07:00
ipc-main-internal-utils.ts fix: strictly validate sender for internal IPC reply channels (#50126) 2026-03-09 10:33:07 +01:00
ipc-main-internal.ts feat: add WebContents.ipc (#34959) 2022-08-03 16:55:12 -07:00
message-port-main.ts fix: make sure classes in lib correctly implement Electron interfaces (#40291) 2023-10-25 14:02:15 -04:00
parse-features-string.ts fix: window.open popups are always resizable (#47540) 2025-07-02 15:02:59 +02:00
rpc-server.ts refactor: replace webFrame.routingId with sync IPC (#47717) 2025-08-02 11:00:42 -04:00
web-view-events.ts chore: bump chromium to 140.0.7281.0 (main) (#47616) 2025-07-14 13:42:37 -07:00