mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
electron/shell
History
trop[bot] 486c264738
fix: don't use deprecate-soon class v8::String::Value (#43552) 
* fix: remove use of deprecated v8::String::Value

Upstream marked v8::String::Value as `V8_DEPRECATE_SOON` last month,
so let's stop using it.

The replacement code mostly does the same as v8::String::Value();
but since our test only cares about the length and not the contents,
we get a small perf win of not needing to allocate a char array and
not needing to call Local::String::Write().

Upstream V8_DEPRECATE_SOON:
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5667299kkk

v8::String::Value() implementation:
20226b740b/src/api/api.cc (10883)

History on why we used it:
80c1a9739d
f49ed30f72

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* Update shell/common/gin_converters/file_path_converter.h

Co-authored-by: Robo <hop2deep@gmail.com>

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fixup! Update shell/common/gin_converters/file_path_converter.h

do not return success for all non-Null non-Strings

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2024-09-04 11:04:53 -05:00
..
app fix: Use XDG_ACTIVATION_TOKEN in wayland when launched by other app (#43548) 2024-09-04 17:27:57 +02:00
browser fix: Use XDG_ACTIVATION_TOKEN in wayland when launched by other app (#43548) 2024-09-04 17:27:57 +02:00
common fix: don't use deprecate-soon class v8::String::Value (#43552) 2024-09-04 11:04:53 -05:00
renderer fix: gin_helper::MicrotasksScope instantiation (#43210) 2024-08-05 15:17:15 -05:00
services/node feat: support app#login event for utility process net requests (#43317) 2024-08-16 11:24:19 +02:00
utility refactor: run Windows SelectFileDialog out of process (#42780) 2024-07-08 10:31:10 +02:00