292dd765b2
`.destroy()` is an important method in the lifecycle of a Node.js Readable stream. It is typically called to reclaim the resources (e.g., close file descriptor). The only situations where calling it manually isn't necessary are when the following events are emitted first: - `end`: natural end of a stream - `error`: stream terminated due to a failure Prior to this commit the ended state was incorrectly tracked together with a pending internal error. It led to situations where the request could get aborted during a read and then get marked as ended (having pending error). With this change we disentangle pending "error" and "destroyed" cases to always properly terminate an active Node.js Readable stream. Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
116 lines
4 KiB
C++
116 lines
4 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef ELECTRON_SHELL_BROWSER_NET_NODE_STREAM_LOADER_H_
|
|
#define ELECTRON_SHELL_BROWSER_NET_NODE_STREAM_LOADER_H_
|
|
|
|
#include <map>
|
|
#include <memory>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "base/memory/raw_ptr.h"
|
|
#include "mojo/public/cpp/bindings/pending_remote.h"
|
|
#include "mojo/public/cpp/bindings/receiver.h"
|
|
#include "mojo/public/cpp/bindings/remote.h"
|
|
#include "mojo/public/cpp/system/data_pipe_producer.h"
|
|
#include "services/network/public/mojom/url_loader.mojom.h"
|
|
#include "services/network/public/mojom/url_response_head.mojom.h"
|
|
#include "v8/include/v8.h"
|
|
|
|
namespace electron {
|
|
|
|
// Read data from node Stream and feed it to NetworkService.
|
|
//
|
|
// This class manages its own lifetime and should delete itself when the
|
|
// connection is lost or finished.
|
|
//
|
|
// We use |paused mode| to read data from |Readable| stream, so we don't need to
|
|
// copy data from buffer and hold it in memory, and we only need to make sure
|
|
// the passed |Buffer| is alive while writing data to pipe.
|
|
class NodeStreamLoader : public network::mojom::URLLoader {
|
|
public:
|
|
NodeStreamLoader(network::mojom::URLResponseHeadPtr head,
|
|
mojo::PendingReceiver<network::mojom::URLLoader> loader,
|
|
mojo::PendingRemote<network::mojom::URLLoaderClient> client,
|
|
v8::Isolate* isolate,
|
|
v8::Local<v8::Object> emitter);
|
|
|
|
// disable copy
|
|
NodeStreamLoader(const NodeStreamLoader&) = delete;
|
|
NodeStreamLoader& operator=(const NodeStreamLoader&) = delete;
|
|
|
|
private:
|
|
~NodeStreamLoader() override;
|
|
|
|
using EventCallback = base::RepeatingCallback<void()>;
|
|
|
|
void Start(network::mojom::URLResponseHeadPtr head);
|
|
void NotifyEnd();
|
|
void NotifyError();
|
|
void NotifyReadable();
|
|
void NotifyComplete(int result);
|
|
void ReadMore();
|
|
void DidWrite(MojoResult result);
|
|
|
|
// Subscribe to events of |emitter|.
|
|
void On(const char* event, EventCallback callback);
|
|
|
|
// URLLoader:
|
|
void FollowRedirect(
|
|
const std::vector<std::string>& removed_headers,
|
|
const net::HttpRequestHeaders& modified_headers,
|
|
const net::HttpRequestHeaders& modified_cors_exempt_headers,
|
|
const std::optional<GURL>& new_url) override {}
|
|
void SetPriority(net::RequestPriority priority,
|
|
int32_t intra_priority_value) override {}
|
|
void PauseReadingBodyFromNet() override {}
|
|
void ResumeReadingBodyFromNet() override {}
|
|
|
|
mojo::Receiver<network::mojom::URLLoader> url_loader_;
|
|
mojo::Remote<network::mojom::URLLoaderClient> client_;
|
|
|
|
raw_ptr<v8::Isolate> isolate_;
|
|
v8::Global<v8::Object> emitter_;
|
|
v8::Global<v8::Value> buffer_;
|
|
|
|
// Mojo data pipe where the data that is being read is written to.
|
|
std::unique_ptr<mojo::DataPipeProducer> producer_;
|
|
|
|
// Whether we are in the middle of write.
|
|
bool is_writing_ = false;
|
|
|
|
// Whether we are in the middle of a stream.read().
|
|
bool is_reading_ = false;
|
|
|
|
size_t bytes_written_ = 0;
|
|
|
|
// When NotifyComplete is called while writing, we will save the result and
|
|
// quit with it after the write is done.
|
|
bool pending_result_ = false;
|
|
int result_ = net::OK;
|
|
|
|
// Set to `true` when we get either `end` or `error` event on the stream.
|
|
// If `false` - we call `stream.destroy()` to finalize the stream.
|
|
bool destroyed_ = false;
|
|
|
|
// When the stream emits the readable event, we only want to start reading
|
|
// data if the stream was not readable before, so we store the state in a
|
|
// flag.
|
|
bool readable_ = false;
|
|
|
|
// It's possible for reads to be queued using nextTick() during read()
|
|
// which will cause 'readable' to emit during ReadMore, so we track if
|
|
// that occurred in a flag.
|
|
bool has_read_waiting_ = false;
|
|
|
|
// Store the V8 callbacks to unsubscribe them later.
|
|
std::map<std::string, v8::Global<v8::Value>> handlers_;
|
|
|
|
base::WeakPtrFactory<NodeStreamLoader> weak_factory_{this};
|
|
};
|
|
|
|
} // namespace electron
|
|
|
|
#endif // ELECTRON_SHELL_BROWSER_NET_NODE_STREAM_LOADER_H_
|