electron/atom/renderer/api
Charles Kerr d663b4eaee
fix: fix gn cpplint warnings (#14583)
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
2018-09-12 19:25:56 -05:00
..
atom_api_renderer_ipc.cc The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
atom_api_renderer_ipc.h refactor: use std::string instead of base::string16 for IPC channel names (ipcRenderer.sendTo) (#14302) 2018-08-24 15:30:10 -07:00
atom_api_spell_check_client.cc The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
atom_api_spell_check_client.h fix: fix gn cpplint warnings (#14583) 2018-09-12 19:25:56 -05:00
atom_api_web_frame.cc The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00
atom_api_web_frame.h The Great Blink mv for source files, part 2. 2018-09-11 20:21:32 +02:00