6ff111a141
* Don't use JSON to send the result of `ipcRenderer.sendSync`.
- Change the return type of AtomViewHostMsg_Message_Sync from `base::string16`
to `base::ListValue`
- Adjust lib/browser/api/web-contents.js and /lib/renderer/api/ipc-renderer.js
to wrap/unwrap return values to/from array, instead of
serializing/deserializing JSON.
This change can greatly improve `ipcRenderer.sendSync` calls where the return
value contains Buffer instances, because those are converted to Array before
being serialized to JSON(which has no efficient way of representing byte
arrays).
A simple benchmark where remote.require('fs') was used to read a 16mb file got
at least 5x faster, not to mention it used a lot less memory. This difference
tends increases with larger buffers.
* Don't base64 encode Buffers
* Don't allocate V8ValueConverter on the heap
* Replace hidden global.sandbox with NodeBindings::IsInitialized()
* Refactoring: check NodeBindings::IsInitialized() in V8ValueConverter
* Refactor problematic test to make it more reliable
* Add tests for NaN and Infinity
81 lines
2.3 KiB
C++
81 lines
2.3 KiB
C++
// Copyright (c) 2014 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "atom/browser/api/event.h"
|
|
|
|
#include "atom/common/api/api_messages.h"
|
|
#include "atom/common/native_mate_converters/string16_converter.h"
|
|
#include "atom/common/native_mate_converters/value_converter.h"
|
|
#include "content/public/browser/render_frame_host.h"
|
|
#include "content/public/browser/web_contents.h"
|
|
#include "native_mate/object_template_builder.h"
|
|
|
|
namespace mate {
|
|
|
|
Event::Event(v8::Isolate* isolate) {
|
|
Init(isolate);
|
|
}
|
|
|
|
Event::~Event() {}
|
|
|
|
void Event::SetSenderAndMessage(content::RenderFrameHost* sender,
|
|
IPC::Message* message) {
|
|
DCHECK(!sender_);
|
|
DCHECK(!message_);
|
|
sender_ = sender;
|
|
message_ = message;
|
|
|
|
Observe(content::WebContents::FromRenderFrameHost(sender));
|
|
}
|
|
|
|
void Event::RenderFrameDeleted(content::RenderFrameHost* rfh) {
|
|
if (sender_ != rfh)
|
|
return;
|
|
sender_ = nullptr;
|
|
message_ = nullptr;
|
|
}
|
|
|
|
void Event::RenderFrameHostChanged(content::RenderFrameHost* old_rfh,
|
|
content::RenderFrameHost* new_rfh) {
|
|
if (sender_ && sender_ == old_rfh)
|
|
sender_ = new_rfh;
|
|
}
|
|
|
|
void Event::FrameDeleted(content::RenderFrameHost* rfh) {
|
|
if (sender_ != rfh)
|
|
return;
|
|
sender_ = nullptr;
|
|
message_ = nullptr;
|
|
}
|
|
|
|
void Event::PreventDefault(v8::Isolate* isolate) {
|
|
GetWrapper()->Set(StringToV8(isolate, "defaultPrevented"), v8::True(isolate));
|
|
}
|
|
|
|
bool Event::SendReply(const base::ListValue& result) {
|
|
if (message_ == nullptr || sender_ == nullptr)
|
|
return false;
|
|
|
|
AtomFrameHostMsg_Message_Sync::WriteReplyParams(message_, result);
|
|
bool success = sender_->Send(message_);
|
|
message_ = nullptr;
|
|
sender_ = nullptr;
|
|
return success;
|
|
}
|
|
|
|
// static
|
|
Handle<Event> Event::Create(v8::Isolate* isolate) {
|
|
return mate::CreateHandle(isolate, new Event(isolate));
|
|
}
|
|
|
|
// static
|
|
void Event::BuildPrototype(v8::Isolate* isolate,
|
|
v8::Local<v8::FunctionTemplate> prototype) {
|
|
prototype->SetClassName(mate::StringToV8(isolate, "Event"));
|
|
mate::ObjectTemplateBuilder(isolate, prototype->PrototypeTemplate())
|
|
.SetMethod("preventDefault", &Event::PreventDefault)
|
|
.SetMethod("sendReply", &Event::SendReply);
|
|
}
|
|
|
|
} // namespace mate
|