87f7625c5d
* chore: bump chromium in DEPS to 96.0.4662.0 * chore: bump chromium in DEPS to 96.0.4663.0 * chore: update patches * [Extensions] Remove RuntimeData entirely3177328* Make helper macros behave consistently for //content/public UserData types3198788* Enabling sandboxing for the speech recognition service browser tests3146090* [devtools] Add 'RegisterPreference' host binding3162281* [Reland][Extensions]: Add persistAcrossSessions flag (scripting API)3175161* [Bluetooth] Add Passkey prompt dialog for bonding.2841104* Clipboard: Remove ReadImage path in browser3194826* Split printing metafile code into its own target.3164925* Cleanup unused DesktopMediaListObserver params3179203* Remove base::DictionaryValue::GetBinary3201974* Window Placement: change RWHV::GetDisplayList to GetScreenInfos3138774* Add a preview to the Tab Capture picker dialog3045268* Add service-based usage to update print settings3155426* chore: bump chromium in DEPS to 96.0.4664.2 * chore: update patches * chore: bump chromium in DEPS to 96.0.4664.4 * chore: update patches * chore: bump chromium in DEPS to 97.0.4666.0 * Revert "chore: bump chromium in DEPS to 97.0.4666.0" This reverts commit d73caae8ba4b39efc9b3ea4de52685b9c92ef3d0. * Reland "Block external protocol handler with sandbox."3198263* fixup for lint * Add CookiePartitionKeychain parameter to CookeManager.GetCookieList.3206016* Move ui/gfx/transform*,rrect*,mask_filter_info* into ui/gfx/geometry3200392* fixup Move ui/gfx/transform*,rrect*,mask_filter_info* into ui/gfx/geometry * ozone: //chrome/browser clean up from USE_X113186490* content: don't load v8 snapshot in browser process3183394* [devtools] Add 'RegisterPreference' host binding3162281* 3186491: Add 'devtools.sync_preferences' preference3186491* 2951147: DCHECK accessible names for focusable Views2951147* 3201014: Use real font size for calculation of SmallTextRatio3201014* fixup Clipboard: Remove ReadImage path in browser * chore: update patches * fix: disable PlzServiceWorker to fix custom protocol SW script loading Ref:3199761Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
49 lines
2.7 KiB
Diff
49 lines
2.7 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: deepak1556 <hop2deep@gmail.com>
|
|
Date: Thu, 20 Sep 2018 17:44:38 -0700
|
|
Subject: dcheck.patch
|
|
|
|
This disables some debug checks which currently fail when running the Electron
|
|
test suite. In general there should be sustained effort to have all debug checks
|
|
enabled. If you want to help, choose one of the diffs below and remove it. Then
|
|
build Electron (debug configuration) and make sure all tests pass on the CI
|
|
systems. Unfortunately the tests don't always cover the check failures, so it's
|
|
good to also run some non-trivial Electron app to verify.
|
|
|
|
Apart from getting rid of a whole diff, you may also be able to replace one diff
|
|
with another which enables at least some of the previously disabled checks. For
|
|
example, the checks might be disabled for a whole build target, but actually
|
|
only one or two specific checks fail. Then it's better to simply comment out the
|
|
failing checks and allow the rest of the target to have them enabled.
|
|
|
|
diff --git a/third_party/blink/renderer/core/mobile_metrics/mobile_friendliness_checker.cc b/third_party/blink/renderer/core/mobile_metrics/mobile_friendliness_checker.cc
|
|
index c490dd7ca2dbe499fbf99509293900318c6b7739..2de3b90801b2daba2eac0263f010c834468b7fd6 100644
|
|
--- a/third_party/blink/renderer/core/mobile_metrics/mobile_friendliness_checker.cc
|
|
+++ b/third_party/blink/renderer/core/mobile_metrics/mobile_friendliness_checker.cc
|
|
@@ -423,7 +423,7 @@ void MobileFriendlinessChecker::ComputeSmallTextRatio(
|
|
->GetPageScaleConstraintsSet()
|
|
.FinalConstraints()
|
|
.initial_scale;
|
|
- DCHECK_GT(initial_scale, 0);
|
|
+ // DCHECK_GT(initial_scale, 0);
|
|
double actual_font_size =
|
|
style.FontSize() * initial_scale / viewport_scalar_;
|
|
double area = text->PhysicalAreaSize();
|
|
diff --git a/ui/base/clipboard/clipboard_win.cc b/ui/base/clipboard/clipboard_win.cc
|
|
index fe8d191217e24b08d36339dbf047beaeb6bd6538..870db0552544e3e89d9498c22ec3db81b46df741 100644
|
|
--- a/ui/base/clipboard/clipboard_win.cc
|
|
+++ b/ui/base/clipboard/clipboard_win.cc
|
|
@@ -891,10 +891,10 @@ SkBitmap ClipboardWin::ReadBitmapInternal(ClipboardBuffer buffer) const {
|
|
|
|
void ClipboardWin::WriteToClipboard(ClipboardFormatType format, HANDLE handle) {
|
|
UINT cf_format = format.ToFormatEtc().cfFormat;
|
|
- DCHECK_NE(clipboard_owner_->hwnd(), nullptr);
|
|
+ // DCHECK_NE(clipboard_owner_->hwnd(), nullptr);
|
|
if (handle && !::SetClipboardData(cf_format, handle)) {
|
|
- DCHECK_NE(GetLastError(),
|
|
- static_cast<unsigned long>(ERROR_CLIPBOARD_NOT_OPEN));
|
|
+ // DCHECK_NE(GetLastError(),
|
|
+ // static_cast<unsigned long>(ERROR_CLIPBOARD_NOT_OPEN));
|
|
::GlobalFree(handle);
|
|
}
|
|
}
|