d586ef2f39
* 🔧 Add security issue detection (and logs) * 🔧 Check for it on load * 👷 Add some tests * 👷 Make the linter happy * 🔧 Allow them to be enabled by force * 📝 Make message slightly prettier * 🔧 Fix a typo in the code comment * 🔧 Classic mistake * 🚀 Optimize things a bit more * 👷 Add tests, fix tests * 📝 Document things * 🔧 Make linter happy * 🔧 One more piece of cleanup
185 lines
4.7 KiB
JavaScript
185 lines
4.7 KiB
JavaScript
const assert = require('assert')
|
|
const http = require('http')
|
|
const fs = require('fs')
|
|
const path = require('path')
|
|
const url = require('url')
|
|
|
|
const {remote} = require('electron')
|
|
const {BrowserWindow} = remote
|
|
|
|
const {closeWindow} = require('./window-helpers')
|
|
|
|
describe('security warnings', () => {
|
|
let server
|
|
let w = null
|
|
let useCsp = true
|
|
|
|
before(() => {
|
|
// Create HTTP Server
|
|
server = http.createServer((request, response) => {
|
|
const uri = url.parse(request.url).pathname
|
|
let filename = path.join(__dirname, './fixtures/pages', uri)
|
|
|
|
fs.stat(filename, (error, stats) => {
|
|
if (error) {
|
|
response.writeHead(404, { 'Content-Type': 'text/plain' })
|
|
response.end()
|
|
return
|
|
}
|
|
|
|
if (stats.isDirectory()) {
|
|
filename += '/index.html'
|
|
}
|
|
|
|
fs.readFile(filename, 'binary', (err, file) => {
|
|
if (err) {
|
|
response.writeHead(404, { 'Content-Type': 'text/plain' })
|
|
response.end()
|
|
return
|
|
}
|
|
|
|
const cspHeaders = { 'Content-Security-Policy': `script-src 'self' 'unsafe-inline'` }
|
|
response.writeHead(200, useCsp ? cspHeaders : undefined)
|
|
response.write(file, 'binary')
|
|
response.end()
|
|
})
|
|
})
|
|
}).listen(8881)
|
|
})
|
|
|
|
after(() => {
|
|
// Close server
|
|
server.close()
|
|
server = null
|
|
})
|
|
|
|
afterEach(() => {
|
|
closeWindow(w).then(() => { w = null })
|
|
|
|
useCsp = true
|
|
})
|
|
|
|
it('should warn about Node.js integration with remote content', (done) => {
|
|
w = new BrowserWindow({ show: false })
|
|
w.webContents.on('console-message', (e, level, message) => {
|
|
assert(message.includes('Node.js Integration with Remote Content'))
|
|
done()
|
|
})
|
|
|
|
w.loadURL(`http://127.0.0.1:8881/base-page-security.html`)
|
|
})
|
|
|
|
it('should warn about disabled webSecurity', (done) => {
|
|
w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
webSecurity: false,
|
|
nodeIntegration: false
|
|
}
|
|
})
|
|
w.webContents.on('console-message', (e, level, message) => {
|
|
assert(message.includes('Disabled webSecurity'))
|
|
done()
|
|
})
|
|
|
|
w.loadURL(`http://127.0.0.1:8881/base-page-security.html`)
|
|
})
|
|
|
|
it('should warn about insecure Content-Security-Policy', (done) => {
|
|
w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
nodeIntegration: false
|
|
}
|
|
})
|
|
|
|
w.webContents.on('console-message', (e, level, message) => {
|
|
assert(message.includes('Insecure Content-Security-Policy'))
|
|
done()
|
|
})
|
|
|
|
useCsp = false
|
|
w.loadURL(`http://127.0.0.1:8881/base-page-security.html`)
|
|
})
|
|
|
|
it('should warn about allowRunningInsecureContent', (done) => {
|
|
w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
allowRunningInsecureContent: true,
|
|
nodeIntegration: false
|
|
}
|
|
})
|
|
w.webContents.on('console-message', (e, level, message) => {
|
|
assert(message.includes('allowRunningInsecureContent'))
|
|
done()
|
|
})
|
|
|
|
w.loadURL(`http://127.0.0.1:8881/base-page-security.html`)
|
|
})
|
|
|
|
it('should warn about experimentalFeatures', (done) => {
|
|
w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
experimentalFeatures: true,
|
|
nodeIntegration: false
|
|
}
|
|
})
|
|
w.webContents.on('console-message', (e, level, message) => {
|
|
assert(message.includes('experimentalFeatures'))
|
|
done()
|
|
})
|
|
|
|
w.loadURL(`http://127.0.0.1:8881/base-page-security.html`)
|
|
})
|
|
|
|
it('should warn about blinkFeatures', (done) => {
|
|
w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
blinkFeatures: ['my-cool-feature'],
|
|
nodeIntegration: false
|
|
}
|
|
})
|
|
w.webContents.on('console-message', (e, level, message) => {
|
|
assert(message.includes('blinkFeatures'))
|
|
done()
|
|
})
|
|
|
|
w.loadURL(`http://127.0.0.1:8881/base-page-security.html`)
|
|
})
|
|
|
|
it('should warn about allowpopups', (done) => {
|
|
w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
nodeIntegration: false
|
|
}
|
|
})
|
|
w.webContents.on('console-message', (e, level, message) => {
|
|
console.log(message)
|
|
assert(message.includes('allowpopups'))
|
|
done()
|
|
})
|
|
|
|
w.loadURL(`http://127.0.0.1:8881/webview-allowpopups.html`)
|
|
})
|
|
|
|
it('should warn about insecure resources', (done) => {
|
|
w = new BrowserWindow({
|
|
show: true,
|
|
webPreferences: {
|
|
nodeIntegration: false
|
|
}
|
|
})
|
|
w.webContents.on('console-message', (e, level, message) => {
|
|
console.log(message)
|
|
assert(message.includes('Insecure Resources'))
|
|
done()
|
|
})
|
|
|
|
w.loadURL(`http://127.0.0.1:8881/insecure-resources.html`)
|
|
w.webContents.openDevTools()
|
|
})
|
|
})
|