mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
electron/shell/browser/ui
History
Charles Kerr 6293bbced0
perf: avoid redundant calls to GetView() (#43216) 
* perf: avoid double-calls to GetView()

There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:

if (auto* view = foo->GetView())
  view->DoSomething();

* perf: avoid discarded GetView() call
2024-08-06 11:25:59 -05:00
..
cocoa chore: bump chromium to 129.0.6630.0 (main) (#43087) 2024-08-02 09:02:11 -05:00
gtk chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
views chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
webui chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
win chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
x chore: bump chromium to 121.0.6159.0 (main) (#40632) 2023-12-11 14:58:26 -06:00
accelerator_util.cc chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
accelerator_util.h chore: enable check raw ptr fields (#38167) 2023-05-11 16:07:39 -04:00
accelerator_util_unittests.cc chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
autofill_popup.cc perf: avoid redundant calls to GetView() (#43216) 2024-08-06 11:25:59 -05:00
autofill_popup.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
certificate_trust.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
certificate_trust_mac.mm chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
certificate_trust_win.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
devtools_manager_delegate.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
devtools_manager_delegate.h chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
devtools_ui.cc chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
devtools_ui.h chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
drag_util.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
drag_util.h chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
drag_util_mac.mm chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
drag_util_views.cc chore: cleanup drag_util (#36806) 2023-01-09 10:00:47 +01:00
electron_desktop_window_tree_host_linux.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
electron_desktop_window_tree_host_linux.h chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
electron_gdk_pixbuf.sigs
electron_gtk.fragment
electron_gtk.sigs
electron_menu_model.cc chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
electron_menu_model.h refactor: inline simple getters, pt . 2 (#41254) 2024-02-09 10:29:14 +01:00
file_dialog.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
file_dialog_linux.cc refactor: prefer std::ranges over base::ranges (#43172) 2024-08-02 21:21:59 -05:00
file_dialog_mac.mm chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
file_dialog_win.cc chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
gtk_util.cc chore: update links in comments (#37197) 2023-02-11 18:52:54 -08:00
gtk_util.h
inspectable_web_contents.cc refactor: prefer std::ranges over base::ranges (#43172) 2024-08-02 21:21:59 -05:00
inspectable_web_contents.h chore: bump chromium to 128.0.6611.0 (main) (#42779) 2024-07-23 08:59:44 -07:00
inspectable_web_contents_delegate.h chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
inspectable_web_contents_view.cc fix: remove InspectableWebContentsViewMac (#43033) 2024-07-27 11:44:22 -05:00
inspectable_web_contents_view.h chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
inspectable_web_contents_view_delegate.cc
inspectable_web_contents_view_delegate.h
inspectable_web_contents_view_mac.h fix: remove InspectableWebContentsViewMac (#43033) 2024-07-27 11:44:22 -05:00
inspectable_web_contents_view_mac.mm chore: more iwyu (#43063) 2024-07-29 12:42:57 -05:00
message_box.h chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
message_box_gtk.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
message_box_mac.mm chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
message_box_win.cc chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
run_all_unittests.cc chore: remove more unused #include calls (#43000) 2024-07-25 11:25:45 +02:00
status_icon_gtk.cc chore: bump chromium to 119.0.6045.0 (main) (#40076) 2023-10-05 19:59:39 -04:00
status_icon_gtk.h chore: bump chromium to 119.0.6045.0 (main) (#40076) 2023-10-05 19:59:39 -04:00
tray_icon.cc feat: add middle click event to tray (#39926) 2023-09-27 14:21:15 -04:00
tray_icon.h chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
tray_icon_cocoa.h chore: add/fix interface comments for sections of methods (#42566) 2024-06-20 10:49:07 +02:00
tray_icon_cocoa.mm chore: remove unused #includes (#42971) 2024-07-22 11:31:32 +02:00
tray_icon_linux.cc chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00
tray_icon_linux.h chore: bump chromium to 116.0.5817.0 (main) (#38465) 2023-06-09 16:08:36 -07:00
tray_icon_observer.h feat: add middle click event to tray (#39926) 2023-09-27 14:21:15 -04:00
tray_icon_win.cc chore: replace absl::optional<T> with std::optional<T> (#40928) 2024-01-10 16:23:35 -06:00