f36ceae024
* chore: migrate from base::StringPiece to std::string_view in keyboard_util.cc
* chore: migrate from base::StringPiece to std::string_view in error_thrower.cc
* chore: migrate from base::StringPiece to std::string_view in electron_api_web_contents.cc
* chore: migrate from base::StringPiece to std::string_view in gin_helper/dictionary.h
* chore: migrate from base::StringPiece to std::string_view in electron_api_url_loader.cc
* chore: phase out internal use of base:::StringPiece
`base::StringPiece` is being phased out upstream. Its code has been
removed upstream and it's just a typedef for `std::string_view`.
They haven't removed the typedef yet, so this PR tries to get ahead
of future breakage by migrating "internal" use (i.e. leaving alone the
places where the `base::StringPiece` name is coming from an upstream
method that we override).
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=691162
Xref: 4294483
Xref: https://docs.google.com/document/d/1d4RnD1uAE2t4iANR0nXy82ASIPGsPuw2mpO6v6T7JKs
36 lines
1.1 KiB
C++
36 lines
1.1 KiB
C++
// Copyright (c) 2019 GitHub, Inc. All rights reserved.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "shell/common/gin_helper/object_template_builder.h"
|
|
|
|
namespace gin_helper {
|
|
|
|
ObjectTemplateBuilder::ObjectTemplateBuilder(
|
|
v8::Isolate* isolate,
|
|
v8::Local<v8::ObjectTemplate> templ)
|
|
: isolate_(isolate), template_(templ) {}
|
|
|
|
ObjectTemplateBuilder& ObjectTemplateBuilder::SetImpl(
|
|
const std::string_view name,
|
|
v8::Local<v8::Data> val) {
|
|
template_->Set(gin::StringToSymbol(isolate_, name), val);
|
|
return *this;
|
|
}
|
|
|
|
ObjectTemplateBuilder& ObjectTemplateBuilder::SetPropertyImpl(
|
|
const std::string_view name,
|
|
v8::Local<v8::FunctionTemplate> getter,
|
|
v8::Local<v8::FunctionTemplate> setter) {
|
|
template_->SetAccessorProperty(gin::StringToSymbol(isolate_, name), getter,
|
|
setter);
|
|
return *this;
|
|
}
|
|
|
|
v8::Local<v8::ObjectTemplate> ObjectTemplateBuilder::Build() {
|
|
v8::Local<v8::ObjectTemplate> result = template_;
|
|
template_.Clear();
|
|
return result;
|
|
}
|
|
|
|
} // namespace gin_helper
|