f36ceae024
* chore: migrate from base::StringPiece to std::string_view in keyboard_util.cc
* chore: migrate from base::StringPiece to std::string_view in error_thrower.cc
* chore: migrate from base::StringPiece to std::string_view in electron_api_web_contents.cc
* chore: migrate from base::StringPiece to std::string_view in gin_helper/dictionary.h
* chore: migrate from base::StringPiece to std::string_view in electron_api_url_loader.cc
* chore: phase out internal use of base:::StringPiece
`base::StringPiece` is being phased out upstream. Its code has been
removed upstream and it's just a typedef for `std::string_view`.
They haven't removed the typedef yet, so this PR tries to get ahead
of future breakage by migrating "internal" use (i.e. leaving alone the
places where the `base::StringPiece` name is coming from an upstream
method that we override).
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=691162
Xref: 4294483
Xref: https://docs.google.com/document/d/1d4RnD1uAE2t4iANR0nXy82ASIPGsPuw2mpO6v6T7JKs
25 lines
792 B
C++
25 lines
792 B
C++
// Copyright 2019 The Chromium Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE.chromium file.
|
|
|
|
#include <string_view>
|
|
|
|
#include "shell/common/gin_helper/arguments.h"
|
|
|
|
#include "v8/include/v8-exception.h"
|
|
namespace gin_helper {
|
|
|
|
void Arguments::ThrowError() const {
|
|
// Gin advances |next_| counter when conversion fails while we do not, so we
|
|
// have to manually advance the counter here to make gin report error with the
|
|
// correct index.
|
|
const_cast<Arguments*>(this)->Skip();
|
|
gin::Arguments::ThrowError();
|
|
}
|
|
|
|
void Arguments::ThrowError(const std::string_view message) const {
|
|
isolate()->ThrowException(
|
|
v8::Exception::Error(gin::StringToV8(isolate(), message)));
|
|
}
|
|
|
|
} // namespace gin_helper
|