![electron-roller[bot]](/assets/img/avatar_default.png)
* chore: bump chromium in DEPS to 136.0.7052.0 * chore: update mas_avoid_private_macos_api_usage.patch.patch6318359
patch applied manually due to context shear * chore: update preconnect_manager.patch Xref:6318420
patch applied manually due to context shear * chore: e patches all * chore: bump chromium to 136.0.7053.1 * chore: update fix_remove_profiles_from_spellcheck_service.patch Xref:6326575
patch applied manually due to context shear * chore: e patches all * chore: revert removal of v8 API used by Node.js * devtools: Remove DevToolsUIBindings::SendJsonRequest() |6326236
* 6244461: Merge //content/common/user_agent.cc into //components/embedder_support:user_agent |6244461
* 6313744: Migrate views::Background factory methods to ColorVariant |6313744
* 6314545: Remove multiple argument support from base::ToString() |6314545
* 6317362: [Extensions] Inline MessagingDelegate::CreateReceiverForTab() |6317362
* 6308998: Add SettingAccess structured metrics event for DevTools |6308998
* 6295214: Remove redundant state field in per-extension preferences |6295214
NB: this change is copied from the upstream change to extensions/shell/browser/shell_extension_loader.cc * fix: ui/ linter error This is showing up in an eslint build step in Electron: > /__w/electron/electron/src/out/Default/gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts > 77:23 error This assertion is unnecessary since the receiver accepts the original type of the expression @typescript-eslint/no-unnecessary-type-assertion > > ✖ 1 problem (1 error, 0 warnings) > 1 error and 0 warnings potentially fixable with the `--fix` option. However, removing the assertion causes a typescript build failure: > gen/ui/webui/resources/cr_elements/preprocessed/cr_menu_selector/cr_menu_selector.ts:77:23 - error TS2345: Argument of type 'HTMLElement | null' is not assignable to parameter of type 'HTMLElement'. > Type 'null' is not assignable to type 'HTMLElement'. > > 77 items.indexOf(this.querySelector<HTMLElement>(':focus')); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ So I think the two different steps may be picking up typescript definitions. This patch should be removed after the issue is tracked down and fixed in a followup task. * fix: -Wnonnull warning Fixes this warning: > 2025-03-07T01:05:01.8637705Z ../../third_party/electron_node/src/debug_utils.cc(257,12): error: null passed to a callee that requires a non-null argument [-Werror,-Wnonnull] > 2025-03-07T01:05:01.8638267Z 257 | return nullptr; > 2025-03-07T01:05:01.8638481Z | ^~~~~~~ > 2025-03-07T01:05:01.8638700Z 1 error generated. Not sure why this warning was never triggered before; `git blame` indicates this code hasn't changed in ages: > c40a8273ef2 (Michaël Zasso 2024-05-10 09:50:20 +0200 255) #endif // DEBUG > 8e2d33f1562 (Anna Henningsen 2018-06-07 16:54:29 +0200 256) } > 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 257) return nullptr; > 247b5130595 (Refael Ackermann 2018-10-22 15:07:00 -0400 258) } Presumably this is failing in this Chromium roll due to a clang version bump. We should remove this patch after upstreaming it. * docs: add upstream pr link for Node patch --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com>
139 lines
4.4 KiB
C++
139 lines
4.4 KiB
C++
// Copyright 2014 The Chromium Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "shell/common/extensions/electron_extensions_client.h"
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
|
|
#include "base/no_destructor.h"
|
|
#include "components/version_info/version_info.h"
|
|
#include "extensions/common/core_extensions_api_provider.h"
|
|
#include "extensions/common/extension_urls.h"
|
|
#include "extensions/common/features/simple_feature.h"
|
|
#include "extensions/common/permissions/permission_message_provider.h"
|
|
#include "extensions/common/url_pattern_set.h"
|
|
#include "shell/common/extensions/electron_extensions_api_provider.h"
|
|
|
|
using extensions::ExtensionsClient;
|
|
|
|
namespace electron {
|
|
|
|
namespace {
|
|
|
|
// TODO(jamescook): Refactor ChromePermissionsMessageProvider so we can share
|
|
// code. For now, this implementation does nothing.
|
|
class ElectronPermissionMessageProvider
|
|
: public extensions::PermissionMessageProvider {
|
|
public:
|
|
ElectronPermissionMessageProvider() = default;
|
|
~ElectronPermissionMessageProvider() override = default;
|
|
|
|
// disable copy
|
|
ElectronPermissionMessageProvider(const ElectronPermissionMessageProvider&) =
|
|
delete;
|
|
ElectronPermissionMessageProvider& operator=(
|
|
const ElectronPermissionMessageProvider&) = delete;
|
|
|
|
// PermissionMessageProvider implementation.
|
|
[[nodiscard]] extensions::PermissionMessages GetPermissionMessages(
|
|
const extensions::PermissionIDSet& permissions) const override {
|
|
return extensions::PermissionMessages();
|
|
}
|
|
|
|
[[nodiscard]] bool IsPrivilegeIncrease(
|
|
const extensions::PermissionSet& granted_permissions,
|
|
const extensions::PermissionSet& requested_permissions,
|
|
extensions::Manifest::Type extension_type) const override {
|
|
// Ensure we implement this before shipping.
|
|
NOTREACHED();
|
|
}
|
|
|
|
[[nodiscard]] extensions::PermissionIDSet GetAllPermissionIDs(
|
|
const extensions::PermissionSet& permissions,
|
|
extensions::Manifest::Type extension_type) const override {
|
|
return {};
|
|
}
|
|
};
|
|
|
|
} // namespace
|
|
|
|
ElectronExtensionsClient::ElectronExtensionsClient()
|
|
: webstore_base_url_(extension_urls::kChromeWebstoreBaseURL),
|
|
new_webstore_base_url_(extension_urls::kNewChromeWebstoreBaseURL),
|
|
webstore_update_url_(extension_urls::kChromeWebstoreUpdateURL) {
|
|
AddAPIProvider(std::make_unique<extensions::CoreExtensionsAPIProvider>());
|
|
AddAPIProvider(std::make_unique<ElectronExtensionsAPIProvider>());
|
|
}
|
|
|
|
ElectronExtensionsClient::~ElectronExtensionsClient() = default;
|
|
|
|
void ElectronExtensionsClient::Initialize() {
|
|
// TODO(jamescook): Do we need to whitelist any extensions?
|
|
}
|
|
|
|
void ElectronExtensionsClient::InitializeWebStoreUrls(
|
|
base::CommandLine* command_line) {}
|
|
|
|
const extensions::PermissionMessageProvider&
|
|
ElectronExtensionsClient::GetPermissionMessageProvider() const {
|
|
NOTIMPLEMENTED();
|
|
|
|
static base::NoDestructor<ElectronPermissionMessageProvider> instance;
|
|
return *instance;
|
|
}
|
|
|
|
const std::string ElectronExtensionsClient::GetProductName() {
|
|
// TODO(samuelmaddock):
|
|
return "app_shell";
|
|
}
|
|
|
|
void ElectronExtensionsClient::FilterHostPermissions(
|
|
const extensions::URLPatternSet& hosts,
|
|
extensions::URLPatternSet* new_hosts,
|
|
extensions::PermissionIDSet* permissions) const {
|
|
NOTIMPLEMENTED();
|
|
}
|
|
|
|
void ElectronExtensionsClient::SetScriptingAllowlist(
|
|
const ExtensionsClient::ScriptingAllowlist& allowlist) {
|
|
scripting_allowlist_ = allowlist;
|
|
}
|
|
|
|
const ExtensionsClient::ScriptingAllowlist&
|
|
ElectronExtensionsClient::GetScriptingAllowlist() const {
|
|
// TODO(jamescook): Real whitelist.
|
|
return scripting_allowlist_;
|
|
}
|
|
|
|
extensions::URLPatternSet
|
|
ElectronExtensionsClient::GetPermittedChromeSchemeHosts(
|
|
const extensions::Extension* extension,
|
|
const extensions::APIPermissionSet& api_permissions) const {
|
|
return {};
|
|
}
|
|
|
|
bool ElectronExtensionsClient::IsScriptableURL(const GURL& url,
|
|
std::string* error) const {
|
|
// No restrictions on URLs.
|
|
return true;
|
|
}
|
|
|
|
const GURL& ElectronExtensionsClient::GetWebstoreBaseURL() const {
|
|
return webstore_base_url_;
|
|
}
|
|
|
|
const GURL& ElectronExtensionsClient::GetNewWebstoreBaseURL() const {
|
|
return new_webstore_base_url_;
|
|
}
|
|
|
|
const GURL& ElectronExtensionsClient::GetWebstoreUpdateURL() const {
|
|
return webstore_update_url_;
|
|
}
|
|
|
|
bool ElectronExtensionsClient::IsBlocklistUpdateURL(const GURL& url) const {
|
|
return false;
|
|
}
|
|
|
|
} // namespace electron
|