67b3fbca89* fix: ensure the inspector agent is shutdown before cleaning up the node env * spec: add tests to ensure clean shutdown with connected inspector agent * Update node_debugger.cc
67 lines
1.8 KiB
C++
67 lines
1.8 KiB
C++
// Copyright (c) 2014 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "atom/browser/node_debugger.h"
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "atom/common/node_includes.h"
|
|
#include "base/command_line.h"
|
|
#include "base/logging.h"
|
|
#include "base/strings/string_util.h"
|
|
#include "base/strings/utf_string_conversions.h"
|
|
#include "libplatform/libplatform.h"
|
|
#include "native_mate/dictionary.h"
|
|
|
|
namespace atom {
|
|
|
|
NodeDebugger::NodeDebugger(node::Environment* env) : env_(env) {}
|
|
|
|
NodeDebugger::~NodeDebugger() {}
|
|
|
|
void NodeDebugger::Start() {
|
|
auto* inspector = env_->inspector_agent();
|
|
if (inspector == nullptr)
|
|
return;
|
|
|
|
std::vector<std::string> args;
|
|
for (auto& arg : base::CommandLine::ForCurrentProcess()->argv()) {
|
|
#if defined(OS_WIN)
|
|
args.push_back(base::UTF16ToUTF8(arg));
|
|
#else
|
|
args.push_back(arg);
|
|
#endif
|
|
}
|
|
|
|
node::DebugOptions options;
|
|
node::options_parser::DebugOptionsParser options_parser;
|
|
std::vector<std::string> exec_args;
|
|
std::vector<std::string> v8_args;
|
|
std::vector<std::string> errors;
|
|
|
|
options_parser.Parse(&args, &exec_args, &v8_args, &options,
|
|
node::options_parser::kDisallowedInEnvironment, &errors);
|
|
|
|
if (!errors.empty()) {
|
|
// TODO(jeremy): what's the appropriate behaviour here?
|
|
LOG(ERROR) << "Error parsing node options: "
|
|
<< base::JoinString(errors, " ");
|
|
}
|
|
|
|
const char* path = "";
|
|
if (inspector->Start(path, options,
|
|
std::make_shared<node::HostPort>(options.host_port),
|
|
true /* is_main */))
|
|
DCHECK(env_->inspector_agent()->IsListening());
|
|
}
|
|
|
|
void NodeDebugger::Stop() {
|
|
auto* inspector = env_->inspector_agent();
|
|
if (inspector && inspector->IsListening())
|
|
inspector->Stop();
|
|
}
|
|
|
|
} // namespace atom
|