mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions
electron/patches/chromium
History
Darshan Sen ec98e95b8a
fix: performance problem in crashReporter.start() on macOS (#34609) 
fix: performance problem in crashReporter.start() on macOS

This change reduces the duration of crashReporter.start() on Intel macOS
from 622 milliseconds to 257 milliseconds!

Backports https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386

  posix: Replace DoubleForkAndExec() with ForkAndSpawn()

  The DoubleForkAndExec() function was taking over 622 milliseconds to run
  on macOS 11 (BigSur) on Intel i5-1038NG7. I did some debugging by adding
  some custom traces and found that the fork() syscall is the bottleneck
  here, i.e., the first fork() takes around 359 milliseconds and the
  nested fork() takes around 263 milliseconds. Replacing the nested fork()
  and exec() with posix_spawn() reduces the time consumption to 257
  milliseconds!

  See https://github.com/libuv/libuv/pull/3064 to know why fork() is so
  slow on macOS and why posix_spawn() is a better replacement.

  Another point to note is that even base::LaunchProcess() from Chromium
  calls posix_spawnp() on macOS -
  8f8d82dea0:base/process/launch_mac.cc;l=295-296

  Change-Id: I25c6ee9629a1ae5d0c32b361b56a1ce0b4b0fd26
  Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/3641386
  Reviewed-by: Mark Mentovai <mark@chromium.org>
  Commit-Queue: Mark Mentovai <mark@chromium.org>

Fixes: https://github.com/electron/electron/issues/34321
Signed-off-by: Darshan Sen <raisinten@gmail.com>
2022-06-20 13:31:29 +09:00
..
.patches fix: performance problem in crashReporter.start() on macOS (#34609) 2022-06-20 13:31:29 +09:00
accelerator.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
add_contentgpuclient_precreatemessageloop_callback.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
add_didinstallconditionalfeatures.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
add_ui_scopedcliboardwriter_writeunsaferawdata.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
add_webmessageportconverter_entangleandinjectmessageportchannel.patch chore: bump chromium to 92.0.4511.0 (master) (#29173) 2021-05-19 16:15:47 -07:00
allow_disabling_blink_scheduler_throttling_per_renderview.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
allow_in-process_windows_to_have_different_web_prefs.patch fix: make preload calculation identical between sandbox & non-sandboxed (#34531) 2022-06-15 13:22:28 -07:00
allow_new_privileges_in_unsandboxed_child_processes.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
allow_setting_secondary_label_via_simplemenumodel.patch chore: bump chromium to 102.0.4971.0 (main) (#33454) 2022-03-30 14:08:58 -04:00
blink_file_path.patch chore: bump chromium to 100.0.4894.0 (main) (#32852) 2022-02-25 13:17:35 -05:00
blink_local_frame.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
boringssl_build_gn.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
breakpad_allow_getting_string_values_for_crash_keys.patch chore: bump chromium to 99.0.4767.0 (main) (#31986) 2022-01-10 17:31:39 -05:00
breakpad_treat_node_processes_as_browser_processes.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
build_add_electron_tracing_category.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
build_disable_partition_alloc_on_mac.patch chore: bump chromium to 102.0.4961.0 (main) (#33091) 2022-03-24 21:39:03 -04:00
build_disable_print_content_analysis.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
build_do_not_depend_on_packed_resource_integrity.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
build_gn.patch chore: bump chromium to 102.0.4961.0 (main) (#33091) 2022-03-24 21:39:03 -04:00
build_libc_as_static_library.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
build_make_libcxx_abi_unstable_false_for_electron.patch chore: bump chromium to 102.0.4961.0 (main) (#33091) 2022-03-24 21:39:03 -04:00
can_create_window.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
chore_do_not_use_chrome_windows_in_cryptotoken_webrequestsender.patch chore: bump chromium to 102.0.4961.0 (main) (#33091) 2022-03-24 21:39:03 -04:00
chore_expose_v8_initialization_isolate_callbacks.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
chore_provide_iswebcontentscreationoverridden_with_full_params.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
chrome_key_systems.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
command-ismediakey.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
crash_allow_disabling_compression_on_linux.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
crash_allow_setting_more_options.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
crashpad_pid_check.patch chore: bump chromium to 102.0.4961.0 (main) (#33091) 2022-03-24 21:39:03 -04:00
custom_protocols_plzserviceworker.patch fix: service worker registration with custom protocols (#34290) 2022-05-23 00:42:37 -07:00
dcheck.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
desktop_media_list.patch chore: bump chromium to 102.0.4989.0 (main) (#33557) 2022-04-12 13:19:14 +02:00
disable-redraw-lock.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
disable_color_correct_rendering.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
disable_compositor_recycling.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
disable_hidden.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
disable_unload_metrics.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
dom_storage_limits.patch chore: bump chromium to 95.0.4612.5 (main) (#30503) 2021-08-23 20:52:17 -04:00
don_t_run_pcscan_notifythreadcreated_if_pcscan_is_disabled.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
don_t_use_potentially_null_getwebframe_-_view_when_get_blink.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
dump_syms.patch chore: bump chromium to 100.0.4894.0 (main) (#32852) 2022-02-25 13:17:35 -05:00
enable_reset_aspect_ratio.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
expose_setuseragent_on_networkcontext.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
extend_apply_webpreferences.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
feat_add_data_parameter_to_processsingleton.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
feat_add_onclose_to_messageport.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
feat_add_set_theme_source_to_allow_apps_to.patch chore: bump chromium to 102.0.4961.0 (main) (#33091) 2022-03-24 21:39:03 -04:00
feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch chore: bump chromium to 102.0.4961.0 (main) (#33091) 2022-03-24 21:39:03 -04:00
feat_add_support_for_overriding_the_base_spellchecker_download_url.patch chore: bump chromium to 102.0.4989.0 (main) (#33557) 2022-04-12 13:19:14 +02:00
feat_allow_embedders_to_add_observers_on_created_hunspell.patch chore: bump chromium to 102.0.4989.0 (main) (#33557) 2022-04-12 13:19:14 +02:00
feat_enable_offscreen_rendering_with_viz_compositor.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
feat_expose_raw_response_headers_from_urlloader.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
feat_filter_out_non-shareable_windows_in_the_current_application_in.patch fix: hide content protected windows during screen capture with ScreenCaptureKitMac (#34362) 2022-05-30 14:13:48 +02:00
fix_adapt_exclusive_access_for_electron_needs.patch fix: esc not working on Windows during fullscreen (#34317) 2022-05-24 21:38:38 -07:00
fix_add_check_for_sandbox_then_result.patch chore: bump chromium to 99.0.4767.0 (main) (#31986) 2022-01-10 17:31:39 -05:00
fix_aspect_ratio_with_max_size.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
fix_crash_when_saving_edited_pdf_files.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
fix_dont_delete_SerialPortManager_on_main_thread.patch chore: bump chromium to 102.0.4989.0 (main) (#33557) 2022-04-12 13:19:14 +02:00
fix_export_zlib_symbols.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
fix_expose_decrementcapturercount_in_web_contents_impl.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
fix_media_key_usage_with_globalshortcuts.patch chore: bump chromium to 102.0.4961.0 (main) (#33091) 2022-03-24 21:39:03 -04:00
fix_non-client_mouse_tracking_and_message_bubbling_on_windows.patch fix: non-client windows messages on legacy widget host (again) (#33438) 2022-03-25 11:12:09 +01:00
fix_patch_out_profile_refs_in_accessibility_ui.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
fix_properly_honor_printing_page_ranges.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
frame_host_manager.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
gin_enable_disable_v8_platform.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
gpu_notify_when_dxdiag_request_fails.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
gritsettings_resource_ids.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
gtk_visibility.patch chore: bump chromium to 102.0.4989.0 (main) (#33557) 2022-04-12 13:19:14 +02:00
hack_plugin_response_interceptor_to_point_to_electron.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
hack_to_allow_gclient_sync_with_host_os_mac_on_linux_in_ci.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
ignore_rc_check.patch chore: bump chromium to 90.0.4415.0 (master) (#27694) 2021-03-04 09:27:05 -08:00
introduce_ozoneplatform_electron_can_call_x11_property.patch fix: calling of X11 functions when running under Wayland (#33355) 2022-03-28 12:48:50 -04:00
isolate_holder.patch chore: bump chromium to 102.0.4999.0 (main) (#33731) 2022-04-22 15:36:22 -07:00
load_v8_snapshot_in_browser_process.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
logging_win32_only_create_a_console_if_logging_to_stderr.patch chore: bump chromium to 102.0.4961.0 (main) (#33091) 2022-03-24 21:39:03 -04:00
make_gtk_getlibgtk_public.patch refactor: use stubs for gdk-pixbuf dependency (#34077) 2022-06-19 17:42:30 -07:00
mas-cgdisplayusesforcetogray.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
mas_avoid_usage_of_private_macos_apis.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
mas_blink_no_private_api.patch chore: put "mas" in the names of mas patches (#29213) 2021-05-19 11:20:12 -07:00
mas_disable_custom_window_frame.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
mas_disable_remote_accessibility.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
mas_disable_remote_layer.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
mas_no_private_api.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
mas_use_public_apis_to_determine_if_a_font_is_a_system_font.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
network_service_allow_remote_certificate_verification_logic.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
notification_provenance.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
pepper_plugin_support.patch chore: bump chromium to 102.0.4961.0 (main) (#33091) 2022-03-24 21:39:03 -04:00
picture-in-picture.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
port_autofill_colors_to_the_color_pipeline.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
posix_replace_doubleforkandexec_with_forkandspawn.patch fix: performance problem in crashReporter.start() on macOS (#34609) 2022-06-20 13:31:29 +09:00
printing.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
process_singleton.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
proxy_config_monitor.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
refactor_expose_cursor_changes_to_the_webcontentsobserver.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
refactor_restore_base_adaptcallbackforrepeating.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
remove_usage_of_incognito_apis_in_the_spellchecker.patch chore: bump chromium to 100.0.4857.0 (main) (#32419) 2022-02-09 18:58:52 -08:00
render_widget_host_view_base.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
render_widget_host_view_mac.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
resource_file_conflict.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
scroll_bounce_flag.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
skip_atk_toolchain_check.patch chore: bump chromium to 100.0.4857.0 (main) (#32419) 2022-02-09 18:58:52 -08:00
support_mixed_sandbox_with_zygote.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
sysroot.patch build: use dev-cdn instead of sysroots s3 bucket (#33922) 2022-04-26 15:21:59 -07:00
unsandboxed_ppapi_processes_skip_zygote.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
upload_list_add_loadsync_method.patch chore: bump chromium to 98.0.4706.0 (main) (#31555) 2021-11-24 09:45:59 +01:00
v8_context_snapshot_generator.patch chore: bump chromium to 100.0.4857.0 (main) (#32419) 2022-02-09 18:58:52 -08:00
web_contents.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
webview_cross_drag.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
webview_fullscreen.patch chore: bump chromium to 104.0.5073.0 (main) (#34272) 2022-06-01 08:12:47 +02:00
worker_context_will_destroy.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00
worker_feat_add_hook_to_notify_script_ready.patch chore: bump chromium to 103.0.5046.0 (main) (#33906) 2022-05-17 12:48:40 -04:00